This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Fix retain cycle for basic ASNetworkImageNodes (allocated without a cache) #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should not directly affect more complex apps that don't use the ASBasicImageDownloader. Also disables the default-on text placeholders, as they churn memory during the measurement pass. These were intended to be written with pure layers (without using backing stores), so I don't think it is a reasonable default-on behavior until that is fixed.
appleguy
added a commit
that referenced
this pull request
Oct 31, 2015
Fix retain cycle for basic ASNetworkImageNodes (allocated without a cache)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not directly affect more complex apps that don't use the ASBasicImageDownloader. Straight alloc/init of ASNetworkImageNode without the cache or downloader options could cause this problem, as well as manually allocating an ASBasicImageDownloader.
Both the downloader and cache are now weak references from the image node, and ASBasicImageDownloader is now a singleton.
This patch also disables the default-on text placeholders, as they churn memory during the measurement pass. They were intended to be written with pure layers (without using backing stores), so I don't
think it is a reasonable default-on behavior until that is fixed.