This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Add "Push Another Copy" to ASViewController demo for memory testing. #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far unable to reproduce the reports of rows or items not being released.
|
Tried adding a reload button as well. Still can't get any leaks to show up, whether reloading a view that's scrolled down and then popping it off the stack, or reloading repeatedly while scrolling around... |
…emory issues No issues found. Have not been able to create a leak either with the test itself or scrolling / popping back view controlliers.
|
I basically tried similar things to reproduce the leaks. But after reading @eanagel comment in #797, I think it could be possible that the number of leaked nodes after each reload/delete is small, but after a while the total number is material. I'm thinking about writing some test cases to assert whether backing stores are correctly removed from the working window. |
appleguy
added a commit
that referenced
this pull request
Nov 5, 2015
Add "Push Another Copy" to ASViewController demo for memory testing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far unable to reproduce the reports of rows or items not being released.
@eanagel, @levi, @nguyenhuy, @ERussel — anyone plz help! I'm more than happy to finish testing & refining the fix that @eanagel has put up, but multiple attempts have never reproduced the issue. I've tried more with ASTableView than ASCollectionView, but in this example with ASCollectionView I still haven't seen the behavior. Here's a memory trace showing about 5 copies of the controller being pushed, scrolled, and popped with no leaks or obvious latent memory shown.