This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Improve cell node layout delegate #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nguyenhuy
commented
Nov 3, 2015
nguyenhuy
commented
- Instead of reloading, layout delegates (i.e ASTableView and ASCollectionView) trigger an empty update transaction after a cell relayout (fix Relayout Cell Node Causes Row to Be Reloaded #808).
- Since delegates don't animate layout changes anymore, revert the animation example in KittenNode.
- Only set a default layout delegate to ASCellNode if it is not provided by the async data source. This allow developers to set their own delegate.
- Address comments in Improve cell node relayout #793.
…empty update transaction, instead of a reload
…d by the async data source
nguyenhuy
force-pushed
the
ImproveCellNodeLayoutDelegate
branch
from
84a5556 to
a6807ef
Compare
There was a problem hiding this comment.
@nguyenhuy for my understanding, why is the check necessary before setting?
There was a problem hiding this comment.
I want to allow developers to set their own layout delegate (in -tableView:nodeForRowAtIndexPath). This checks make sure if developer indeed provides such delegate, it is not overridden here.
|
Great patch! Thank you for carefully watching community feedback for your changes and iterating on them — a real dedication to polish and proper API design in the period of time where we can easily make changes. Very important and a great example to set. |
appleguy
added a commit
that referenced
this pull request
Nov 9, 2015
Improve cell node layout delegate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.