Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

levi
Copy link
Contributor

@levi levi commented Nov 19, 2015

I'm currently reading through range controller and saw a few things that needed some syntax and organization clean up:

  • Removed deprecated layout controller methods that were long longer needed.
    • Now that we're closer to a 2.0, we should start the discussion of removing the remaining deprecated methods that live in ASDisplayNode—there are only three.
  • Cleaned up syntax usage in ASRangeController
  • Separated data and callback methods into data source and delegate protocols, respectively. It's now a little clearer what data is required for the range controller to work. In the process, I reordered some of the naming of the methods to make them a bit more readable.

@levi levi changed the title Remove deprecated layout controller methods Clean up syntax and organization of ASRangeController Nov 20, 2015
@appleguy
Copy link
Contributor

Looks great, no changes requested before landing!

appleguy added a commit that referenced this pull request Nov 24, 2015
Clean up syntax and organization of ASRangeController
@appleguy appleguy merged commit 15f718d into facebookarchive:master Nov 24, 2015
peter-iakovlev pushed a commit to peter-iakovlev/AsyncDisplayKit that referenced this pull request Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants