This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Inline supplementary kind iteration in data controller #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice refinement, thanks! |
appleguy
added a commit
that referenced
this pull request
Dec 7, 2015
Inline supplementary kind iteration in data controller
peter-iakovlev
pushed a commit
to peter-iakovlev/AsyncDisplayKit
that referenced
this pull request
Jul 21, 2018
…rarely-changed ones). (facebookarchive#918) * [ASTextNode2] Upgrade lock safety by protecting all ivars (including rarely-changed ones). Although I don't know of any specific crashes caused by this, I think we should lock all properties by default. There are also some indications of premature optimization in keeping lock scope small, where it is actually important to have transactional integrity, and also where the ASDisplayNode base class is otherwise going to repeatedly re-lock the object anyway. I think this will remain pretty efficient, especially with os_unfair_lock enabled. * Use compare-assign macros
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.