[ASPagerNode] Initial implementation of a paging-specific ASCollectionNode subclass. #925
Conversation
There was a problem hiding this comment.
We probably wanna expose things like this so people can get spacing between pages
There was a problem hiding this comment.
Yes, definitely agreed. Next changes!
|
@levi thanks for building this! Several folks are quite excited to start using it, both at Pinterest and beyond :). When you get a chance, can you fix the issue that the build server is flagging? |
levi
force-pushed
the
levi/pager-node
branch
from
ef6d992 to
dc6d9d2
Compare
levi
force-pushed
the
levi/pager-node
branch
from
e1a75ba to
669fd38
Compare
|
@appleguy added a few helper methods locally that I'd like to begin adding after this patch lands. You ok landing this? |
There was a problem hiding this comment.
It is essential that we set these in -didLoad, not in -init. Some big perf problems in Pinterest were addressed by ensuring we didn't poke the creation of ASCollectionViews too early.
|
This is a great first start, thanks @levi ! If you can address comments in a followup diff, that would be awesome and almost surely enough for me to adopt this in Pinterest this weekend! |
[ASPagerNode] Initial implementation of a paging-specific ASCollectionNode subclass.
appleguy
changed the title
…l in setAnimatedImage #trivial (facebookarchive#925) * [ASNetworkImageNodeTests] Add defaultImage test and improve image test. #trivial * [ASImageNode+AnimatedImage] Fix early return when animatedImage is nil in setAnimatedImage. #trivial
4 participants
This is a pretty simple implementation to get the ball rolling on the API design and control behavior. I'm currently developing this control in tandem at the NFL for an update on how we navigate between weeks in a given season. Let's get a discussion going on how we could develop this in a meaningful way for other groups to use.