This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Fix ASTextNode size calculation when paragraphstyle has linespacing #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtNode size calculation
|
Could this have anything to do with #940? |
|
Thanks @bsmith11 that's interesting. Possibly related if linespacing calculation in NSLayoutManager is broken in general, however I wasn't using NSUnderlineStyleAttributeName in my project or in the ASTextNodeTest |
|
I'll test it out on |
There was a problem hiding this comment.
What if the paragraph style changes at some point through the text? Just not supported?
There was a problem hiding this comment.
Good point and you caught my laziness :) modified it to only take the paragraph style of the last visible glyph and it still fixed it.
|
closing and reopening to trigger travis build |
|
After setting up test code to verify if TextKit is bugged, I think the issue might be in the truncation logic. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #930 and fixes ASTextNodeTest size recalculation tests when there is a non-zero NSParagraphyStyle lineSpacing.
I could only get the updated ASTextNodeTest tests to pass when I increased the height of the rect returned by usedRectForTextContainer by exactly linespacing in ASTextKitRenderer's
_calculateSizemethod. I suspect the calculation doesn't take the linespacing of the last line into account.I couldn't find any issues within ASDK code so I suspected it is a bug with TextKit or NSLayoutManager but if anyone could find the root cause in ASDK that is obviously a better fix.