This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Fix ASTextNode truncated size calculation ignoring attributes in the last line #941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #930
ASTextNode
usesASTextKitTailTruncater
to calculate the size of the rendered truncated text by replacing the last line with the_composedTruncationString
if the text is long enough to truncate.However
_composedTruncationString
doesn't have attributes from_attributedString
at the time of size calculation so attributes such asNSParagraphStyle
were being omitted resulting in an incorrect size.We fix this by syncing attributes of
_composedTruncationString
with_attributedString
whenever_attributedString
is updated inASTextNode
.We also updated
ASTextNodeTests
to test for different line spacing applied throughout text.