Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

bsmith11
Copy link

Fixed ASTextKit CoreText attributes bug which was incorrectly reading an NSParagraphStyle as CTParagraphStyleRef

… a NSParagraphStyle as CTParagraphStyleRef
@bsmith11
Copy link
Author

#940

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after // - also should go ahead and link to this issue or give slightly more description on the expected behavior, as it currently is unclear why we'd want an unsupported attribute to make it through

@appleguy
Copy link
Contributor

@bsmith11 thanks so much for debugging this and taking the time to implement & test a fix! I am bummed this issue slowed down your development, though.

I have to admit that I am not familiar with this CoreText attribute cleansing code and its original or current purpose. It seems like this basically circumvents that for a certain class of CT properties, which I certainly agree shouldn't be filtered out, although it's hard for me to say if this breaks a perhaps even rarer edge case originally intended to be addressed by the attribute cleansing. I think this is better than it was before, so in it goes!

appleguy added a commit that referenced this pull request Dec 18, 2015
ASTextKit CoreText attributes cleansing should not remove NSParagraphStyle attributes
@appleguy appleguy merged commit 3b5fb17 into facebookarchive:master Dec 18, 2015
@appleguy appleguy added this to the 1.9.4 milestone Dec 18, 2015
@appleguy appleguy added the Bug label Dec 18, 2015
peter-iakovlev pushed a commit to peter-iakovlev/AsyncDisplayKit that referenced this pull request Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants