This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Remove CALayer and UIView implementations of "name" property. #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids CoreAnimation from capturing the name from a background thread deep within the internals of AVPlayerLayer, which commits transactions off the main thread. If the main thread is also accessing properties that require the lock, in very specific app architectures relying on AVPlayerLayer, this can cause a deadlock. The "name" property is primarily used by ASDK's unit test infrastructure, so I'm leaving it in place for that purpose - and it may still be used for debugging, if someone wants to set it. It will remain possible to get the node from a layer or view with asyncdisplaykit_node, and access name from there.
|
This should, with almost total certainty, resolve #948. Shady Apple! |
appleguy
added a commit
that referenced
this pull request
Dec 19, 2015
Remove CALayer and UIView implementations of "name" property.
|
Didn't know what seems to be a simple and harmless property can mess up On Sat, Dec 19, 2015, 3:34 AM appleguy notifications@github.com wrote:
Regards, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids CoreAnimation from capturing the name from a background thread deep within the internals
of AVPlayerLayer, which commits transactions off the main thread. If the main thread is also accessing
properties that require the lock, in very specific app architectures relying on AVPlayerLayer, this
can cause a deadlock.
The "name" property is primarily used by ASDK's unit test infrastructure, so I'm leaving it in place for
that purpose - and it may still be used for debugging, if someone wants to set it. It will remain
possible to get the node from a layer or view with asyncdisplaykit_node, and access name from there.