Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

aaronschubert0
Copy link
Contributor

This fixes #971 as raised by @tomizimobile. It also greatly improves the internal logic of ASMapNode. Most notably:

  • You can now set _liveMap = YES on a background thread, and it will only be actioned when that node comes on screen.
  • Added asserts to handle layer backing scenarios.
  • Added a few additional comments to improve documentation.

Will add an example app and tests in a future diff (soon :D )
@appleguy

@aaronschubert0 aaronschubert0 changed the title Greatly improve the internal logic of ASMapNode. Also fixes bug #971 [ASMapNode] Greatly improve the internal logic of ASMapNode. Also fixes bug #971 Dec 23, 2015
@appleguy appleguy added this to the 1.9.4 milestone Dec 23, 2015
@appleguy
Copy link
Contributor

@aaronschubert0 awesome, thanks for the ultra fast turnaround! This component has already attracted a variety of users, and in January it will be put into the new Pinterest too :).

appleguy added a commit that referenced this pull request Dec 23, 2015
[ASMapNode] Greatly improve the internal logic of ASMapNode. Also fixes bug #971
@appleguy appleguy merged commit c968b8d into facebookarchive:master Dec 23, 2015
@appleguy
Copy link
Contributor

@aaronschubert0 I didn't realize until now all the options that MKMapSnapshotOptions provides - wow! Later we should consider adding some more passthroughs. I'm pretty sure we can treat that object as thread safe, so it may actually be ideal to just change the region property into the MKMapSnapshotOptions object (I had not realized this is how the snapshotter itself gets the region until converting some Pinterest code to use ASMapNode, and then noticed it would be an even more convenient conversion if it just took the same object).

@appleguy
Copy link
Contributor

#988

@aaronschubert0
Copy link
Contributor Author

@appleguy Wow!! That's super awesome. Can't wait for that update! Good start to the New Year.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ASMapNode] Snapshot size / zoom level may not always be invalidated at the right times.

3 participants