Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix man page (#403) #404

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Fix man page (#403) #404

merged 1 commit into from
Jul 5, 2021

Conversation

thiagowfx
Copy link
Contributor

  • Updates man page with newly added flags since 2015. Man page had been
    last updated only in 2015.
  • Fix formatting of flags in man page. Instead of joining lines, now
    each flag is correctly displayed in its own line, making it easier to
    read.
  • Fix man page generation script, which was broken and still referencing
    the old usageStrings.py (correct filename is usage_strings.py).

@facebook-github-bot
Copy link

Hi @thiagowfx!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@KapJI
Copy link
Member

KapJI commented Jul 2, 2021

Please format your code using black.

- Updates man page with newly added flags since 2015. Man page had been
  last updated only in 2015.
- Fix formatting of flags in man page. Instead of joining lines, now
  each flag is correctly displayed in its own line, making it easier to
  read.
- Fix man page generation script, which was broken and still referencing
  the old usageStrings.py (correct filename is usage_strings.py).
@thiagowfx
Copy link
Contributor Author

Done.

@KapJI
Copy link
Member

KapJI commented Jul 5, 2021

Thanks!

@KapJI KapJI merged commit a661e28 into facebook:master Jul 5, 2021
pcottle pushed a commit that referenced this pull request Feb 23, 2022
- Updates man page with newly added flags since 2015. Man page had been
  last updated only in 2015.
- Fix formatting of flags in man page. Instead of joining lines, now
  each flag is correctly displayed in its own line, making it easier to
  read.
- Fix man page generation script, which was broken and still referencing
  the old usageStrings.py (correct filename is usage_strings.py).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants