Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing a newly drawn way causes the last way segment to disappear #660

Closed
Bonkles opened this issue Nov 21, 2022 · 2 comments
Closed

Closing a newly drawn way causes the last way segment to disappear #660

Bonkles opened this issue Nov 21, 2022 · 2 comments
Assignees
@Bonkles
Labels
bug Something isn't working

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Nov 21, 2022 •
edited
Loading

When we draw a new way with 'n' segments, you can connect the way to its original node via snapping. However, once this happens, the last segment of the way is unwound and you end up with an open way with 'n-1' segments- all but the last one.
@Bonkles Bonkles added the bug Something isn't working label Nov 21, 2022
@Bonkles Bonkles self-assigned this Nov 21, 2022
Bonkles added a commit that referenced this issue Nov 21, 2022
@Bonkles
Fix #660 by not unwinding the last history change when we're clicking…
e215e20 
… the starting node to finish the way.
@Bonkles
Copy link
Contributor Author

Bonkles commented Nov 21, 2022

Fixed- when we click a node to finish the way, we used to assume that we needed to back out the 'drawing' node that was created after the last click. This is correct in most normal cases, but in this case there was no 'drawing' node to back out, and we ended up getting rid of a good node.

@Bonkles
Copy link
Contributor Author

Bonkles commented Nov 21, 2022

Fixed in e215e20ba.

@Bonkles Bonkles closed this as completed Nov 21, 2022
@Bonkles Bonkles mentioned this issue Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bonkles Bonkles

Labels
bug Something isn't working
Projects
Rapid v2 Beta Board
Status: 🏁 Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bonkles