Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile pass: Ensure that mouse/touch events work correctly #749

Closed
Bonkles opened this issue Jan 3, 2023 · 3 comments
Closed

Mobile pass: Ensure that mouse/touch events work correctly #749

Bonkles opened this issue Jan 3, 2023 · 3 comments
Assignees
@Bonkles
Milestone
v2 General Beta (...

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Jan 3, 2023 •
edited
Loading

When using the v2 alpha 3 on mobile, the zoom factor gets set to NaN/NaN. This apparently also happens from desktop chrome with a simulated pixel 5 selected.

Finally, rendering a specific object fails to work too: https://mapwith.ai/rapid-v2-alpha3#id=w808726001
@Bonkles Bonkles added this to the v2 General Beta (Extended) milestone Jan 3, 2023
@Bonkles Bonkles self-assigned this Jan 3, 2023
@jleedev
Copy link

jleedev commented Jan 3, 2023

Well, w808726001 has since been deleted. However, any large enough area seems to not render.

https://mapwith.ai/rapid-v2-alpha3#id=r188553 works.
https://mapwith.ai/rapid-v2-alpha3#id=r2563472 does not.

@Bonkles
Copy link
Contributor Author

Bonkles commented Jan 19, 2023

Okay, at long last- some progress. We've figured out that we were depending on event.movementX/Y to be present in our map 'pointermove' events, but that is only a thing when a mouse is available. Instead we will synthesize our own 'movementX/Y' coords by saving the last pointermove event, comparing the clientX and clientY coords.

This worked in some initial testing I did with my pixel 3A XL.

@bhousel bhousel mentioned this issue Jan 20, 2023
Closed
Bonkles added a commit that referenced this issue Jan 20, 2023
@Bonkles
WIP #749: Get panning working on mobile once more.
52d1081
Bonkles added a commit that referenced this issue Jan 24, 2023
@Bonkles
Fix #749 by removing the 'over renderer' checks inherent in the selec…
c4e5ca5 
…t and draw behavior- they were unnecessary.
@Bonkles
Copy link
Contributor Author

Bonkles commented Jan 26, 2023

Further updates: This seems to work on my iPad 9th gen. It will ship in the beta coming out very soon(tm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bonkles Bonkles

Labels
None yet
Projects
Rapid v2 Beta Board
Status: Pending Release
Milestone
v2 General Beta (Extended)
Development

No branches or pull requests
2 participants
@jleedev @Bonkles