Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapillary segment lines not stitched together across some tile boundaries #776

Closed
bhousel opened this issue Jan 30, 2023 · 2 comments
Closed

Mapillary segment lines not stitched together across some tile boundaries #776

bhousel opened this issue Jan 30, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@bhousel
Copy link
Contributor

bhousel commented Jan 30, 2023 •
edited
Loading

We fetch the Mapillary data in z14-sized tiles. It looks like when a segment crosses a tile boundary we aren't stitching together the segments properly. This probably got introduced when the code got switched to consuming the Mapillary vector tile api.

Screenshot 2023-01-30 at 3 43 51 PM

Screenshot 2023-01-30 at 3 43 36 PM

Screenshot 2023-01-30 at 3 43 04 PM
@bhousel bhousel added the bug Something isn't working label Jan 30, 2023
@bhousel
Copy link
Contributor Author

bhousel commented Jan 30, 2023

Before we were treating each sequenceID as a unique feature.
This adds an extra level of nesting to properly deal with sequences that cross tile boundaries.
They aren't actually "stitched", but I'll take it 😆

Screenshot 2023-01-30 at 5 33 38 PM

@bhousel
Copy link
Contributor Author

bhousel commented Jan 31, 2023

Still seeing an issue with Kartaview when we start out on a different tile and enter it.
Screenshot 2023-01-31 at 9 12 41 AM

@bhousel bhousel reopened this Jan 31, 2023
bhousel added a commit that referenced this issue Mar 6, 2023
@bhousel
Fix bug in filtering Mapillary sequences
571c50c 
Note - Sequences now contains an Array of Linestrings, post #776
We were treating them as an Array, but they are now Array of Arrays.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhousel