Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Vector tile data display crashes under load #795

Closed
Bonkles opened this issue Feb 8, 2023 · 1 comment
Closed

Custom Vector tile data display crashes under load #795

Bonkles opened this issue Feb 8, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Feb 8, 2023

Description

It appears that loading custom vector tile data can, in certain circumstances, cause RapiD v2 to give up and fall over. Severe slowdowns, not showing all the data in each layer, etc. are just a couple of the issues we're seeing in internal testing.

Version

2.0.0-beta.0

What browser are you seeing the problem on? What version are you running?

Chrome 109.0.5414.119

Steps to reproduce

Load custom vector tile data using the Map Data (F) menu, click 'edit custom map data' button, paste the vector tile data URL, observe RapiD slow to a crawl / not display everything.

The browser URL at the time you encountered the bug

http://127.0.0.1:8080/#background=Maxar-Premium&datasets=fbRoads,msBuildings&disable_features=boundaries&map=15.00/48.8742/2.3415 but with an internal vector tile dataset.

@Bonkles Bonkles self-assigned this Feb 8, 2023
@Bonkles Bonkles added this to the v.next milestone Feb 8, 2023
@bhousel bhousel added the bug Something isn't working label Feb 8, 2023
@Bonkles
Copy link
Contributor Author

Bonkles commented Feb 13, 2023

Fixed in e8e79c5.

There were a few issues here:

  1. Container ids for custom data containers had 'undefined' elements
  2. The projection being fed into the custom data viewer didn't have a projection boundary- so only tiles in the upper left of the screen were being loaded on startup.
  3. Ensure that we re-render any custom data features that get updated (say, those getting merged into other features with the same feature class).

bhousel pushed a commit that referenced this issue Mar 2, 2023
…data, and by fixing the 'undefined' labels for custom feature containers.
@bhousel bhousel removed this from the v.next milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Pending Release
Development

No branches or pull requests

2 participants