Integrate colorblind and map color scheme UI to preference tab #1365
Conversation
Add default and example color scheme objects to colors.json. Minify colors.json in build_data.js. Add colors.json to DataLoaderSystem's fileMap. Add color scheme helper functions to StyleSytem, with comments to describe each functions parameters and return values (where applicable). Update StyleSystem's styleMatch() function to interact with color scheme objects from colors.json rather than from STYLE_DECLARATIONS. Fix white space discrepancies in StyleSystem. Update color_selection.js and colorblind_mode_options.js to use StyleSystem rather than the non-existent ColorSystem. Uncomment color schemes and colorblind mode options sections in preferences.js to add them to the Preferences pane of the UI. Refs: Issue facebook#1230
Rename example color scheme to high_contrast to reflect its functionality in colors.json Update core.yaml to match the renamed example color scheme Reduce boilerplate code and comments relating to color scheme handling in StyleSystem.js Add missing semicolon in build_data.js to facilitate formatting consistency Refs: Issue facebook#1230
|
Hi @chinweibegbu! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
As this was an example PR just for demo purposes, I will close it. We will do a more formal review of the same content at a later time! |
Add default and example color scheme objects to
colors.json. Rename example color scheme object tohigh_contrastto reflect functionality incolors.jsonandcore.yamlMinify
colors.jsoninbuild_data.js. Addcolors.jsontoDataLoaderSystem'sfileMap.Add color scheme helper functions to
StyleSytem, with comments to describe each functions parameters and return values (where applicable).Update
StyleSystem'sstyleMatch()function to interact with color scheme objects fromcolors.jsonrather than fromSTYLE_DECLARATIONS.Fix white space discrepancies in
StyleSystem.js.Reduce boilerplate code and comments relating to color scheme handling in
StyleSystem.js.Update
color_selection.jsandcolorblind_mode_options.jsto useStyleSystemrather than the non-existentColorSystem.Uncomment color schemes and colorblind mode options sections in
preferences.jsto add them to the Preferences pane of the UI.Refs: Issue #1230