-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Buck parses build files in buck-out #527
Comments
buck test
intereferes with output files written by Eclipsebuck test
interferes with output files written by Eclipse
You shouldn't be writing or modifying files in Can you change your eclipse project to output to a directory that isn't in It's pretty silly of Buck to be parsing build files in there though. |
We could probably introduce |
Moving Eclipse output from
Now you are screwed up, because Buck copying all files to
So now, all
https://gerrit-review.googlesource.com/#/c/72684/1/polygerrit-ui/app/BUCK@41 |
Good point. @shs96c something else to keep in mind for how the new FileHashCache should work. |
buck test
interferes with output files written by EclipseThe new Buck version fixed annoying stdout spamming bug on unit test failures: [1]. Now we can revert our monkey patching hack to prevent that. Since [2] Buck interferes with files in buck-out directory: [3]. Switch to using eclipse-out directory as Eclipse output directory instead. For this change it's necessary to clean up buck-out directory, otherwise `buck test` would fail. This version also fixed "Python client lost connection" bug: [4]. This reverts commit 94e93aa. [1] facebook/buck#505 [2] facebook/buck@35cb495 [3] facebook/buck#527 [4] facebook/buck#534 Change-Id: I4cd1a99ce9d0615713c235d873e6cdd61b1854bb
From what I can gather not really knowing the code,
It looks like some places it is called don't ever put ignore paths in: https://github.com/facebook/buck/search?utf8=%E2%9C%93&q=DirectoryTraversal%28 Then again, the project filesystem appears to ignore it:
And parsing build files appears to use it:
Might be a good place to poke around and send in a patch if you find the issue! |
Trying to upgrade Buck to recent master: [1] reveals that
buck test
is inherently broken. It interferes with Eclipse output directory (written tobuck-out/eclipse
) with errors like:Note, that we are using Eclipse and telling it to use
buck-out/eclipse
as output drectory:So Eclipse is copying all files (except
*.java
) to this directory:My impression is that Buck is trying to parse Buck files from this output directory.
I've tracked down the problem to this commit:
35cb495 is the first bad commit
Steps to reproduce:
git clone https://gerrit.googlesource.com/gerrit
.buckversion
buck test --include api
-> all is finebuck-out/eclipse
buck test --include api
is failing with error mentioned above[1] https://gerrit-review.googlesource.com/72682
The text was updated successfully, but these errors were encountered: