Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Extend BuildTargetParser to understand cell based rules #658

Closed
davido opened this issue Feb 16, 2016 · 2 comments
Closed

Extend BuildTargetParser to understand cell based rules #658

davido opened this issue Feb 16, 2016 · 2 comments

Comments

@davido
Copy link
Contributor

davido commented Feb 16, 2016

Given a repository definition:

[repositories]
  jgit = lib/jgit

I would expect, that something like this should just work:

  $ buck build "\@jgit//:jgit"
  BUILD FAILED: Build target path cannot be absolute or contain . or .. (found //\@jgit:jgit)

Unfortunately it doesn't.

lucamilanesio pushed a commit to GerritCodeReview/gerrit that referenced this issue Apr 20, 2016
Cross cell support in Buck is considered as experimental feature, with
number of open issues: [1], [2], [3].  Moreover, to make Maven Central
machinery work, it was needed to create symbolic links in source tree.
That broke `buck targets` feature.

Remove it for now, and re-consider to add it later.

[1] facebook/buck#656
[2] facebook/buck#658
[3] facebook/buck#717

Bug: Issue 3954
Change-Id: Ic621a07771f926001df181b46b2169e214ce208a
@mzlee
Copy link
Contributor

mzlee commented Apr 21, 2016

So the underlying issue is in the CommandLineTargetNodeSpecParser which doesn't take into account the cross cell. We're currently working on this, and moving away from using '@' to specify the cross cell to prevent the '@' command line functionality from args4j. Instead, you should be able to use jgit//:jgit.

@davido
Copy link
Contributor Author

davido commented Apr 22, 2016

Thanks! We were forced to temporarily remove jgit cross cell support in Gerrit Code Review, as we don't have a workaround for now for: #717. One it's solved we re-consider to add it again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants