Added Find Owning View Controller command #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shortcut is `fovc`. Given an input `UIView` this command will walk the next responder chain until it fines the UIViewController that owns this view.
| return 'fovc' | ||
|
|
||
| def descriptino(self): | ||
| return 'Find the view controller that owns the input view' |
| def nextResponder(object): | ||
| command = '[((id){}) nextResponder]'.format(object) | ||
| nextResponder = fb.evaluateObjectExpression(command) | ||
| if int(nextResponder, 0): |
There was a problem hiding this comment.
I think this should be try/except instead of if/else.
There was a problem hiding this comment.
@kastiglione Unless I'm missing something (I'm fairly new to Python) we still need an if statement. "0x000000" is a valid return value and is what my original int() conversion was designed to catch. I did wrap the int() function in an exception block, though.
There was a problem hiding this comment.
I see what you mean. This looks good to me. @kastiglione what do you think?
There was a problem hiding this comment.
Yes, I misunderstood the original intention of catching 0x000000. 👍
added 2 commits
March 9, 2014 15:30
fvc will default to searching for view controllers via class name regex. If the --view option is set, we can search for the owning view controller.
|
I think I've addressed all the comments. Please let me know if I've missed anything or if you notice any issues! |
|
Looks great, thanks! |
arigrant
added a commit
that referenced
this pull request
Mar 15, 2014
Added Find Owning View Controller command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortcut is
fovc. Given an inputUIViewthis command will walk the nextresponder chain until it finds the
UIViewControllerthat owns this view.