Show compile time

[alexnewmannn]

Hey,
Apologies if it's been asked before but the issue uses very generic terms and I can't find any code for it, or any issues.
But is it possible to show how long each compile takes, for example. "Compiled successfully in 1234ms" I guess https://github.com/facebookincubator/create-react-app/blob/2069e8ac43c4765f1698091d3985ecb70ba88089/packages/react-scripts/scripts/build.js#L75

I can potentially have a look at this and see how other plugins do it, but wondered if it was possible already and if its a desired feature.

Cheers!

edit: I did this work so I could use it locally, I've also submitted a Pull Request if this is of interest to you, below are some screenshots

[tbillington]

You can time the command from your terminal eg time npm run build. Other people might be using yarn though, which prints out the time the command took at the end.

[alexnewmannn]

@tbillington Yeh that would work for build but not dev with watch commands, for example gulp will show how long each task took to calculate, webpack on its own does as well if i remember correctly, would just be good to see the time taken for each dev compile :)

[tbillington]

Ahh, I see :) I'd also find that interesting.

[gaearon]

Can you explain more why this is useful? It's useful for people with custom builds since it's actionable, but doesn't seem very useful if you can't tweak the config.

[alexnewmannn]

@gaearon you're right about it not being actionable under most circumstances. the way i see it is as follows:

• for users deciding on whether to use react-scripts or not it shows how fast it really is, how fast initial build is and how fast watched compiles are and shows why it may be more (or less, but in my opinion more) or a viable option to use than others
• users going from gulp or other frameworks are used to it and see it as a valuable metric.
• hopefully (definitely did where i work) encourages users to take a look at their own code to see if there's anything that can be improved to speed things up, maybe too many deps
• for users who eject it's a good base to start with as they can now action on the slower build times
• also a nice metric internally to see whether updates to react-scripts is improving compile time

More than anything it's just a good stat to know, i know for a fact i and many others like to see how long compiling is taking (also if it's slower than usual it's usually a good time to close some browser tabs 👀)
it's something i thought was missing 😀

[gaearon]

I think these are convincing arguments, but I'd like to see the number less emphasized in the output (e.g. it's not more important than warnings themselves).

[nanxiaobei]

After I adjusted the project directory structure, the compilation speed has slowed down. really need to see the compile time to improve speed.

[alexnewmannn]

I had a PR open for this but it got a bit stale so has since been closed, I will try pick it up again this weekend if I get some spare time

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[stale]

This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue.