Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails when packages set under devDependencies #3977

Closed
scazzy opened this issue Feb 5, 2018 · 1 comment
Closed

Build fails when packages set under devDependencies #3977

scazzy opened this issue Feb 5, 2018 · 1 comment

Comments

@scazzy
Copy link

scazzy commented Feb 5, 2018

Is this a bug report?

Yes

Did you try recovering your dependencies?

Yes

Which terms did you search for in User Guide?

Some github issues and discord

Environment

  1. yarn v1.3.2
  2. Ejected

Then, specify:

  1. Operating system: Linux
  2. Browser and version (if relevant): CI/CD

Steps to Reproduce

  1. setup build and deploy pipeline in GoCD
  2. Yarn install - successfull
  3. NODE_ENV=production Yarn build - failed.

Expected Behavior

Should be able to build successfully

I had moved some non-critical devDeps unner devDeps in package.json. Worked smooth on local builds with and without prod mode. Fails on GoCD, asking for most/every package as dependency. Including chalk and webpack.

Actual Behavior

image

@Timer
Copy link
Contributor

Timer commented Feb 5, 2018

Sorry, but this question isn't related to CRA.

It appears your CI doesn't install dev deps, though. Please consult with GoCD's support if you can't get this working.

[this is why in a non-ejected setup we save react-scripts under dependencies -- it belongs there]

@Timer Timer closed this as completed Feb 5, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants