Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-add storybook && update the documentation and links #2331

Merged
merged 2 commits into from
Jun 4, 2017
Merged

re-add storybook && update the documentation and links #2331

merged 2 commits into from
Jun 4, 2017

Conversation

ndelangen
Copy link
Contributor

I re-enabled the storybook section, and updated the documentation and links.

Can you please review but not yet merge?

This is because our 3.0.0 release is not yet released. Though this is about to happen (expected to be this week).

If you have any comments or question, just let me know!

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@bernard-lin
Copy link

Hurray! 🎊

@gaearon
Copy link
Contributor

gaearon commented May 24, 2017

Looks good. Let me know when you're ready.

@ndelangen
Copy link
Contributor Author

READY! We just released Storybook 3.0.0 ! 🎉

@ndelangen
Copy link
Contributor Author

Can we get this merged @gaearon ?

@luftywiranda13
Copy link
Contributor

I've tried the v3. no issue so far, great!

@Timer
Copy link
Contributor

Timer commented Jun 4, 2017

Thanks guys!

@Timer Timer merged commit e898215 into facebook:master Jun 4, 2017
@ndelangen ndelangen deleted the re-add_storybook branch June 4, 2017 17:52
@gaearon
Copy link
Contributor

gaearon commented Jun 4, 2017

We should also review the Styleguidist PR now.

paweljedrzejczyk pushed a commit to paweljedrzejczyk/create-react-app that referenced this pull request Jun 12, 2017
@backstroke-bot @paweljedrzejczyk
Update from upstream repo facebookincubator/create-react-app (#1)
16c642e 
* Update Travis CI Node versions in User Guide (facebook#2454)

Removed Node v4 (CRA only supports Node >= 6)

* re-add storybook && update the documentation and links (facebook#2331)

* re-add storybook && update the documentation and links

* Change to new documentation domain

* Prioritize index.css over the implicit App.css (facebook#2470)

* Added NamedModulesPlugin in webpack.config.dev.js (facebook#2458)

* Added NamedModulesPlugin in webpack.config.dev.js

* Update webpack.config.dev.js

* Unscope detect-port (facebook#2483)

Resolves facebook#2481

* Update webpack links to point to webpack 2 (facebook#2492)

* Update README.md to make links to webpack point to webpack.js.org instead
  insteade of webpack 1 webpack.githup.io

* chore(templates): Move GitHub templates to hidden .github folder (facebook#2489)

* Fix minor docs typo (facebook#2500)

* Fix link to Storybook docs (facebook#2521)

* Simplify flow init docs (facebook#2522)

- Call `npm run flow --init` won't create a .flowconfig file, it should be `npm run flow init`
@gaearon gaearon mentioned this pull request Jun 28, 2017
Merged
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
@ndelangen @romaindso
re-add storybook && update the documentation and links (facebook#2331)
d50ab7d 
* re-add storybook && update the documentation and links

* Change to new documentation domain
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
@ndelangen @wmonk
re-add storybook && update the documentation and links (#2331)
864ef28 
* re-add storybook && update the documentation and links

* Change to new documentation domain
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ndelangen @facebook-github-bot @bernard-lin @gaearon @luftywiranda13 @Timer