Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add storybook && update the documentation and links #2331

Merged
merged 2 commits into from Jun 4, 2017

Conversation

Projects
None yet
6 participants
@ndelangen
Copy link
Contributor

commented May 22, 2017

I re-enabled the storybook section, and updated the documentation and links.

Can you please review but not yet merge?

This is because our 3.0.0 release is not yet released. Though this is about to happen (expected to be this week).

If you have any comments or question, just let me know!

@facebook-github-bot

This comment has been minimized.

Copy link

commented May 22, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot

This comment has been minimized.

Copy link

commented May 22, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@bernard-lin

This comment has been minimized.

Copy link

commented May 22, 2017

Hurray! 🎊

@gaearon

This comment has been minimized.

Copy link
Member

commented May 24, 2017

Looks good. Let me know when you're ready.

@ndelangen

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2017

READY! We just released Storybook 3.0.0 ! 🎉

@ndelangen

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2017

Can we get this merged @gaearon ?

@luftywiranda13

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2017

I've tried the v3. no issue so far, great!

@Timer

This comment has been minimized.

Copy link
Collaborator

commented Jun 4, 2017

Thanks guys!

@Timer Timer merged commit e898215 into facebook:master Jun 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ndelangen ndelangen deleted the ndelangen:re-add_storybook branch Jun 4, 2017

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 4, 2017

We should also review the Styleguidist PR now.

paweljedrzejczyk added a commit to paweljedrzejczyk/create-react-app that referenced this pull request Jun 12, 2017

Update from upstream repo facebookincubator/create-react-app (#1)
* Update Travis CI Node versions in User Guide (facebook#2454)

Removed Node v4 (CRA only supports Node >= 6)

* re-add storybook && update the documentation and links (facebook#2331)

* re-add storybook && update the documentation and links

* Change to new documentation domain

* Prioritize index.css over the implicit App.css (facebook#2470)

* Added NamedModulesPlugin in webpack.config.dev.js (facebook#2458)

* Added NamedModulesPlugin in webpack.config.dev.js

* Update webpack.config.dev.js

* Unscope detect-port (facebook#2483)

Resolves facebook#2481

* Update webpack links to point to webpack 2 (facebook#2492)

* Update README.md to make links to webpack point to webpack.js.org instead
  insteade of webpack 1 webpack.githup.io

* chore(templates): Move GitHub templates to hidden .github folder (facebook#2489)

* Fix minor docs typo (facebook#2500)

* Fix link to Storybook docs (facebook#2521)

* Simplify flow init docs (facebook#2522)

- Call `npm run flow --init` won't create a .flowconfig file, it should be `npm run flow init`

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

re-add storybook && update the documentation and links (facebook#2331)
* re-add storybook && update the documentation and links

* Change to new documentation domain

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

re-add storybook && update the documentation and links (#2331)
* re-add storybook && update the documentation and links

* Change to new documentation domain

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.