Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to action button now "reacts" to being hovered :) #6810

Merged
merged 4 commits into from Apr 25, 2019

Conversation

@joerez
Copy link
Contributor

commented Apr 13, 2019

Added a slight scale up on the get started button upon hover.

Call to action button "reacts" to being hovered :)
Slight scale up on the get started button upon hover.

@joerez joerez requested review from amyrlam and iansu as code owners Apr 13, 2019

@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 13, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 13, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot

This comment has been minimized.

Copy link

commented Apr 13, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@amyrlam

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

It's strange there is no change on hover!

Maybe we should go with a simpler fix - perhaps a color change, for us turn white on hover - similar to https://docusaurus.io/ or https://sorbet.org/. That would also match the styling of the edit button on https://facebook.github.io/create-react-app/docs/getting-started. What do you think?

@amyrlam amyrlam self-assigned this Apr 25, 2019

@joerez

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

It's strange there is no change on hover!

Maybe we should go with a simpler fix - perhaps a color change, for us turn white on hover - similar to https://docusaurus.io/ or https://sorbet.org/. That would also match the styling of the edit button on https://facebook.github.io/create-react-app/docs/getting-started. What do you think?

I think that's a good idea!

@joerez

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

@amyrlam That change has been made.

@amyrlam
Copy link
Collaborator

left a comment

Made a couple suggestions, let me know.

Thanks for making the changes! 👍

Show resolved Hide resolved docusaurus/website/static/css/custom.css Outdated
Show resolved Hide resolved docusaurus/website/static/css/custom.css Outdated

amyrlam and others added some commits Apr 25, 2019

Update docusaurus/website/static/css/custom.css
Co-Authored-By: joerez <rezenbiz@gmail.com>
Update docusaurus/website/static/css/custom.css
Co-Authored-By: joerez <rezenbiz@gmail.com>
@joerez

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

Nit is good. Suggestions added.

@amyrlam amyrlam added this to the 3.0.1 milestone Apr 25, 2019

@amyrlam
Copy link
Collaborator

left a comment

💯

@amyrlam amyrlam merged commit 18b399b into facebook:master Apr 25, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

@lock lock bot locked and limited conversation to collaborators Apr 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.