Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade webpack to 4.35.0 to fix dynamic import issue #7257

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Upgrade webpack to 4.35.0 to fix dynamic import issue #7257

merged 2 commits into from
Jun 24, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Jun 21, 2019

Fixes #7254

@iansu iansu added this to the 3.0.2 milestone Jun 21, 2019
@iansu
Copy link
Contributor Author

iansu commented Jun 21, 2019

I hope this fixes the issue anyway. If CI passes I'll look into adding a test to verify the fix and make sure it doesn't break again.

mrmckeb
mrmckeb approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you've reviewed the changelog, and this passes the CI, so approved from me!

@ianschmitz
Copy link
Contributor

Whoops. Double approved! 😛

@mrmckeb
Copy link
Contributor

mrmckeb commented Jun 24, 2019

@ianschmitz is excited about this PR!

iansu
iansu commented Jun 24, 2019
View reviewed changes
packages/react-scripts/fixtures/kitchensink/src/App.js
@@ -241,6 +241,11 @@ class App extends Component {
this.setFeature(f.default)
);
break;
case 'dynamic-import':
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this even work? Also, the tests themselves use a dynamic import and they didn't break previously.

@iansu iansu merged commit a88a4c3 into facebook:master Jun 24, 2019
@iansu
Copy link
Contributor Author

iansu commented Jun 24, 2019

🤷‍♂

@lock lock bot locked and limited conversation to collaborators Jun 29, 2019
@iansu iansu deleted the update-webpack branch October 17, 2019 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrmckeb mrmckeb mrmckeb approved these changes

@ianschmitz ianschmitz ianschmitz approved these changes

@amyrlam amyrlam Awaiting requested review from amyrlam

@bugzpodder bugzpodder Awaiting requested review from bugzpodder

@gaearon gaearon Awaiting requested review from gaearon

@petetnt petetnt Awaiting requested review from petetnt

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

Update webpack to fix dynamic imports
4 participants
@iansu @ianschmitz @mrmckeb @facebook-github-bot