Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing-library related npm package names in README #7340

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

balazsorban44
Copy link
Contributor

A minor name change, jest-dom has also been moved to @testing-library.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@petetnt petetnt changed the title Update npm package names Update testing-library related npm package names in README Jul 9, 2019
Copy link
Contributor

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balazsorban44
Copy link
Contributor Author

@iansu @amyrlam

@bugzpodder bugzpodder added this to the 3.1 milestone Jul 27, 2019
@bugzpodder bugzpodder added this to In progress in v3.1 via automation Jul 27, 2019
@iansu iansu merged commit 567f36c into facebook:master Jul 29, 2019
v3.1 automation moved this from In progress to Done Jul 29, 2019
@iansu
Copy link
Contributor

iansu commented Jul 29, 2019

Thanks!

@balazsorban44 balazsorban44 deleted the patch-1 branch July 29, 2019 17:24
@lock lock bot locked and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
v3.1
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants