Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed backToTopButton hook #10138

Closed
wants to merge 1 commit into from
Closed

Conversation

Raj-Mandal-20
Copy link

Pre-flight checklist

Related issues/PRs

Fixes #10135

@facebook-github-bot
Copy link
Contributor

Hi @Raj-Mandal-20!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

netlify bot commented May 14, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 0fcaf79
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6643d5fbf254cd0008d4e54c
😎 Deploy Preview https://deploy-preview-10138--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 68 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 64 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 68 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 62 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 69 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 14, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

I'll turn it as a draft for now because we are still unsure of what we want to implement exactly.

See discussions here: #10135 (comment)

@slorber slorber marked this pull request as draft May 23, 2024 11:45
@Raj-Mandal-20
Copy link
Author

@slorber Apart from this do we have any Slack or Discord channel for communication?

@slorber
Copy link
Collaborator

slorber commented May 24, 2024

@slorber Apart from this do we have any Slack or Discord channel for communication?

We have a Discord server that you can find in the website footer

@slorber
Copy link
Collaborator

slorber commented Aug 2, 2024

Thanks for your PR

Unfortunately we have decided to not implement this for now.
See #10135 (comment)

@slorber slorber closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the backtotopbutton only shows when scrolling up slightly after scrolling down
3 participants