fix: edit url should support versioned subdirectories #1154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1153
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Create
learn/01-intro-to-muster.md
Before
After
Solution Explained:
Simple regex fix. This is because we should lazyly quantify the preceding characters to match the subdirectories
Example:
version-.*?\/(.*\.md)
forversion-1.0.11/learn/01-intro-to-muster.md
islearn/01-intro-to-muster.md
but
version-.*\/(.*\.md)
forversion-1.0.11/learn/01-intro-to-muster.md
is01-intro-to-muster.md
which is wrong