Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: showcase user Scalafmt #1250

Merged
merged 4 commits into from
Feb 27, 2019
Merged

docs: showcase user Scalafmt #1250

merged 4 commits into from
Feb 27, 2019

Conversation

ahtee
Copy link
Contributor

@ahtee ahtee commented Feb 26, 2019

added scalameta object

Motivation

(Write your motivation here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

added scalameta object
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 26, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 7d0f1ec

https://deploy-preview-1250--docusaurus-preview.netlify.com

@ahtee ahtee changed the title Update users.js docs: showcase user Scalafmt 🎉 Feb 26, 2019
@ahtee ahtee changed the title docs: showcase user Scalafmt 🎉 docs: showcase user Scalafmt Feb 26, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 7717a14

https://deploy-preview-1250--docusaurus-preview.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Feb 26, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 2584773

https://deploy-preview-1250--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ahtee! The formatting checks are failing, so please run Prettier from yarn prettier in the root and update the PR and it will be good to merge 😄

@ahtee
Copy link
Contributor Author

ahtee commented Feb 26, 2019

Nice work @ahtee! The formatting checks are failing, so please run Prettier from yarn prettier in the root and update the PR and it will be good to merge 😄

My bad will run in about 2 hours and then will update the PR :)

@yangshun yangshun merged commit 006f705 into facebook:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants