Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tutorial #1381

Merged
merged 3 commits into from
Apr 23, 2019
Merged

feat: add tutorial #1381

merged 3 commits into from
Apr 23, 2019

Conversation

yangshun
Copy link
Contributor

Motivation

Add a tutorial to guide people on how to publish their first site. It's still WIP but I will finish it sometime over the next few days.

If you feel we should not show it in the header until it's done, I can hide it first.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See Netlify.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@yangshun yangshun requested a review from endiliey as a code owner April 23, 2019 06:43
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 23, 2019
@endiliey
Copy link
Contributor

Deploy preview for docusaurus-2 failed.

Built with commit 559f4fb

https://app.netlify.com/sites/docusaurus-2/deploys/5cbeb419cf5a6a0008c2cdcc

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 559f4fb

https://deploy-preview-1381--docusaurus-preview.netlify.com

@endiliey endiliey self-assigned this Apr 23, 2019
Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tried to read it couple of times and the workflow is pretty ok. There are several TODO text found, hope you'll fix it in the future

After reading it, I was thinking if it was better fit to be put as a Blog Post..

@yangshun
Copy link
Contributor Author

After reading it, I was thinking if it was better fit to be put as a Blog Post..

Blog posts are there for v1 and v2, so I don't think this is too appropriate. Also, putting it as a separate page allows us to break the tutorial down into smaller pages for better navigation.

@yangshun yangshun merged commit 23e56f6 into master Apr 23, 2019
@yangshun yangshun deleted the tutorial branch April 23, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants