Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blog docs example as object property #1403

Merged
merged 1 commit into from
Apr 27, 2019
Merged

fix: blog docs example as object property #1403

merged 1 commit into from
Apr 27, 2019

Conversation

juanpicado
Copy link
Contributor

Motivation

The property is part of website/siteConfig.js and the example looks like a sentence.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Not need it.

Related PRs

No PRs related

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 27, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit dedf059

https://deploy-preview-1403--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit dedf059

https://deploy-preview-1403--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you @juanpicado!

@yangshun yangshun merged commit 7ebcf10 into facebook:master Apr 27, 2019
@juanpicado juanpicado deleted the patch-1 branch April 28, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants