perf(v2): replace unnecessary json stringify(string) with inline string #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
added
the
pr: performance
|
Deploy preview for docusaurus-2 ready! Built with commit fd142fa |
|
Deploy preview for docusaurus-preview ready! Built with commit fd142fa |
yangshun
approved these changes
Nov 24, 2019
|
previously it wasnt a string. Its an object iirc. Some refactor did previously and sometimes miss this small detail |
|
Seems like regression. Need to revert this. Turns out I put JSON.stringify previously to escape backslash on windows. Should've put comment lol.. |
|
Haha we should have also went to see the commit in the past to see why we added that (isn't always useful, but could be useful). Feel free to revert. |
|
Doing it tonight. I am quite occupied this week with personal stuff (eg: renewing my passport) |
endiliey
added a commit
that referenced
this pull request
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Rather than doing stringify for simple string like below
Better do
https://jsperf.com/stringifyvsdirect/1
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)