Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): improve stylelint copyright header rule #2363

Merged
merged 2 commits into from
Mar 7, 2020
Merged

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Mar 6, 2020

Motivation

Improve the stylelint copyright rule by @scottilee.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

CI

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 6, 2020
"description": "stylelint plugin to check css files for a copyright header",
"main": "index.js",
"license": "MIT",
"scripts": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test command for the rule.

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Mar 6, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 155f1be

https://deploy-preview-2363--docusaurus-2.netlify.com

@yangshun yangshun merged commit 6cc0aa2 into master Mar 7, 2020
@yangshun yangshun deleted the yangshun/stylelint branch March 7, 2020 03:50
@yangshun yangshun added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants