Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix svg loader #3202

Merged
merged 3 commits into from
Aug 5, 2020
Merged

fix(v2): fix svg loader #3202

merged 3 commits into from
Aug 5, 2020

Conversation

anshulrgoyal
Copy link
Contributor

Motivation

Fix issue #3179

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

By adding dogfood

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 3, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 3, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 87a566a

https://deploy-preview-3202--docusaurus-2.netlify.app

@anshulrgoyal anshulrgoyal changed the title fix loader feat(v2): fix svg loader Aug 4, 2020
@anshulrgoyal anshulrgoyal changed the title feat(v2): fix svg loader fix(v2): fix svg loader Aug 4, 2020
@slorber
Copy link
Collaborator

slorber commented Aug 5, 2020

LGTM thanks, just updated a bit the doc to make it reliable regarding versioning as relative path to statics may break

@slorber slorber linked an issue Aug 5, 2020 that may be closed by this pull request
@anshulrgoyal
Copy link
Contributor Author

LGTM thanks, just updated a bit the doc to make it reliable regarding versioning as relative path to statics may break

ok

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 5, 2020
@slorber slorber merged commit 25b70b5 into facebook:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline SVGs not rendering and break page
4 participants