Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): upgrade dependencies #3727

Merged
merged 5 commits into from Nov 12, 2020
Merged

chore(v2): upgrade dependencies #3727

merged 5 commits into from Nov 12, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 11, 2020

Motivation

Bump deps. There is a slight decrease in all website bundles from 2.41 MB to 2.34 MB.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Starting dev server and building website works correctly (tested with this script)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from slorber as a code owner November 11, 2020 22:07
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 11, 2020
@netlify
Copy link

netlify bot commented Nov 11, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 6ff7960

https://deploy-preview-3727--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Nov 12, 2020

thanks, that looks safe to upgrade

@slorber slorber merged commit 049634a into master Nov 12, 2020
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 12, 2020
@Simek
Copy link
Contributor

Simek commented Nov 12, 2020

@lex111 @slorber - It looks like this dependencies bump breaks the V1 build on CI - #3730

@HonkingGoose
Copy link
Contributor

I have a problem with my syntax highlighting in code blocks breaking on @mdx-js/react v1.6.21 where it was working before on 1.6.19. Are you not having this problem with your update?

See mdx-js/mdx#1320 for a full report of this problem.

@lex111
Copy link
Contributor Author

lex111 commented Nov 12, 2020

I ran into this problem, but it turned out that one more dependency had to be updated to set things right (it seems it was related to loader-utils dep, I don't remember exactly).

@HonkingGoose
Copy link
Contributor

Well I managed to fix my problem by upgrading other dependencies as well. That was a good tip! Thank you @lex111! 😄

I really don't know what the specific troublemaker is for my problem. But it's fixed for now at least. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants