Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal): add yarn deduplicate script, cleanup lock #3738

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Nov 13, 2020

Motivation

This small PR deduplicates yarn lock file using yarn-deduplicate package. It also adds the deduplicate script as lock:update command. Let me know if you would like also to see this in postinstall (to automatically optimize lock on every dependency change).

You can read more about what the script does and why it's important in the Readme section:

This might also fix the problems with the old, pinned packages, which are lately emerging in the repository (see related PRs).

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Successful build and run of Docusuaurus V2 website on my local machine.

Related PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 13, 2020
@netlify
Copy link

netlify bot commented Nov 13, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 3fe54a3

https://deploy-preview-3738--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Nov 13, 2020

thanks, I'm ok to have this on postinstall

@slorber
Copy link
Collaborator

slorber commented Nov 13, 2020

can it messup with yarn 2 users?

@slorber
Copy link
Collaborator

slorber commented Nov 13, 2020

yarn lock conflict now :)

@Simek
Copy link
Contributor Author

Simek commented Nov 13, 2020

@slorber Conflict has been created after the merge of #3716. Might be wise to rerun the lock script after that merge on this branch.

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 13, 2020
@slorber slorber merged commit 73f151d into facebook:master Nov 13, 2020
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants