Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(showcase): "much more pages" => "many more pages" #6091

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

favna
Copy link
Contributor

@favna favna commented Dec 11, 2021

Motivation

Something that a friend noticed when I was sharing screenshots of the preview deploy of #6090, figured I might as well fix it right away.

For the sake of explaining the change if at all necessary, here's a good StackExchange: https://english.stackexchange.com/a/47921. TL;DR is that it's "many more" with countable nouns, and pages are countable.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Yes

Related PRs

N.A.

@netlify
Copy link

netlify bot commented Dec 11, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 69e3b40

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61b3fe2027aaa00007e755b1

😎 Browse the preview: https://deploy-preview-6091--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 75
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6091--docusaurus-2.netlify.app/

@Josh-Cena
Copy link
Collaborator

I would deem them as equally correct. In a related thread: https://english.stackexchange.com/questions/371335/much-many-fewer

Generally, "many more pages than X" means "there are many pages; more pages than X" where "many" is an adjective. "Much more pages than X" means "more pages than X" where "much" is an adverb describing the extent of "more".

@Josh-Cena
Copy link
Collaborator

Anyways, I guess "many more" sounds more natural. Would still be willing to merge this, just waiting for the CLA bot to wake up

@Josh-Cena Josh-Cena changed the title docs: change much more pages for many more pages docs(showcase): "much more pages" => "many more pages" Dec 11, 2021
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 11, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 11, 2021
@Josh-Cena Josh-Cena merged commit 2cc3322 into facebook:main Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants