Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add sapphire to showcase #6090

Merged
merged 3 commits into from
Dec 11, 2021

Conversation

favna
Copy link
Contributor

@favna favna commented Dec 10, 2021

Motivation

We have started using Docusaurus for the Sapphire project a while back and I figured hey why not add it to the list.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

None.

Related PRs

None.

@favna
Copy link
Contributor Author

favna commented Dec 10, 2021

Uh I have no what's up with the Netlify deploy. It says Input file contains unsupported image format but I only added a .png image, same as all the other users.

@armano2
Copy link
Contributor

armano2 commented Dec 10, 2021

even github has an issue with this image, you should try taking new one

https://github.com/facebook/docusaurus/blob/d0a627da1fa1c3dbcff921c84155f5a5663ef7c6/website/src/data/showcase/sapphire.png

�PNG
�

@armano2

This comment has been minimized.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 10, 2021
@favna
Copy link
Contributor Author

favna commented Dec 10, 2021

That's really odd. I used the upload function in github.dev. I'll upload a new one by actually cloning my fork.

@netlify
Copy link

netlify bot commented Dec 10, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 6c4b05f

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61b3f492e8af8b00081e959b

😎 Browse the preview: https://deploy-preview-6090--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 10, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 72
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6090--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena changed the title feat(users): add sapphire to docusaurus users docs: add sapphire to showcase Dec 11, 2021
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants