Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: correct docs linking for custom defaultVersionShown #894

Merged
merged 1 commit into from
Aug 11, 2018
Merged

Fix: correct docs linking for custom defaultVersionShown #894

merged 1 commit into from
Aug 11, 2018

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Aug 9, 2018 •
edited
Loading

Motivation

Fix facebook/react-native-website#505

If we set defaultVersionShown in Docusaurus

const siteConfig = {
  defaultVersionShown: '1.3.1',
  // .....
};

When we go to http://localhost:3000/docs/en/1.3.1/site-preparation the docs linking is wrong, it became http://localhost:3000/docs/en/installation instead of http://localhost:3000/docs/en/1.3.1/installation

before

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

After this PR the docs linking is now correct

after

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 9, 2018
@endiliey endiliey mentioned this pull request Aug 9, 2018
Closed
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 509646d

https://deploy-preview-894--docusaurus-preview.netlify.com

@endiliey endiliey requested a review from yangshun August 9, 2018 17:29
JoelMarcey
JoelMarcey approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks!

@JoelMarcey
Copy link
Contributor

@yangshun Seem reasonable to you?

@yangshun yangshun merged commit 8f9f7a5 into facebook:master Aug 11, 2018
@yangshun
Copy link
Contributor

Yes, thanks @endiliey!

@endiliey endiliey deleted the defaultVer branch September 5, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

@JoelMarcey JoelMarcey JoelMarcey approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@endiliey @docusaurus-bot @JoelMarcey @yangshun @facebook-github-bot