fix(core): conditionally include hostname parameter when using…

[jack-robson]

… detect port

• Skip adding the hostname parameter if the host is "localhost".

Pre-flight checklist

• I have read the Contributing Guidelines on pull requests.
• If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
• If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fixing bugs for Hacktoberfest.

This closes #8202

Don't think it warrants a unit test for this, but LMK if you disagree.

Test Plan

How do you know this change has worked?

Previously, if user starts a node server using

const http = require("http");

const port = 3000;

const requestListener = function (req, res) {
  res.writeHead(200);
  res.end("My first server!");
};

const server = http.createServer(requestListener);

server.listen(port, () => {
  console.log(`Server is running on http://localhost:${port}`);
});

And they were to start a docusaurus project, it would not detect the above script running on 3000, and therefore start docusaurus on 3000 too.

The workaround before this PR was to specifically add the "localhost" host property into the other apps code:

server.listen(port, "localhost", () => {

But this PR avoids the user having todo that, and still supports and server.listen(port, "localhost", () => { use cases.

Test links

Deploy preview: https://deploy-preview-9407--docusaurus-2.netlify.app/

Related issues/PRs

#8202

[facebook-github-bot]

Hi @jack-robson!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[netlify]

✅ [V2]

Built without sensitive environment variables

Name	Link
🔨 Latest commit	e5b6a47
🔍 Latest deploy log	https://app.netlify.com/sites/docusaurus-2/deploys/652d2fd02496000008fec285
😎 Deploy Preview	https://deploy-preview-9407--docusaurus-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

⚡️ Lighthouse report for the deploy preview of this PR

URL	Performance	Accessibility	Best Practices	SEO	PWA	Report
/	🟠 72	🟢 97	🟢 92	🟢 100	🟠 89	Report
/docs/installation/	🟠 70	🟢 98	🟢 92	🟢 100	🟠 89	Report
/docs/category/getting-started/	🟠 78	🟢 100	🟢 92	🟢 90	🟠 89	Report
/blog/	🟠 83	🟢 100	🟢 92	🟢 90	🟠 89	Report
/blog/preparing-your-site-for-docusaurus-v3/	🟠 71	🟢 97	🟢 92	🟢 100	🟠 89	Report
/blog/tags/release/	🟠 76	🟢 100	🟢 92	🟠 80	🟠 89	Report
/blog/tags/	🟠 84	🟢 100	🟢 92	🟢 90	🟠 89	Report

[slorber]

Thanks, that looks like a good-enough fix 👍