fix(content-blog): add baseUrl for author.image_url #9581

OzakIOne · 2023-11-24T15:53:10Z

Pre-flight checklist

I have read the Contributing Guidelines on pull requests.
If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fix: #9577

Test Plan

Local builds & unit tests

Test links

Deploy preview: https://deploy-preview-9581--docusaurus-2.netlify.app/

Related issues/PRs

#9577

netlify · 2023-11-24T15:57:49Z

✅ [V2]

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`f008026`
🔍 Latest deploy log	https://app.netlify.com/sites/docusaurus-2/deploys/6564b2346ec5ff0008dd17d4
😎 Deploy Preview	https://deploy-preview-9581--docusaurus-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2023-11-24T15:59:29Z

⚡️ Lighthouse report for the deploy preview of this PR

URL	Performance	Accessibility	Best Practices	SEO	PWA	Report
/	🟠 64	🟢 98	🟢 100	🟢 100	🟠 89	Report
/docs/installation	🟠 68	🟢 98	🟢 100	🟢 100	🟠 89	Report
/docs/category/getting-started	🟠 75	🟢 100	🟢 100	🟢 90	🟠 89	Report
/blog	🟠 74	🟢 100	🟢 100	🟢 90	🟠 89	Report
/blog/preparing-your-site-for-docusaurus-v3	🟠 60	🟢 97	🟢 100	🟢 100	🟠 89	Report
/blog/tags/release	🟠 73	🟢 100	🟢 100	🟠 80	🟠 89	Report
/blog/tags	🟠 76	🟢 100	🟢 100	🟢 90	🟠 89	Report

slorber

Thanks, almost good but a few changes needed

packages/docusaurus-plugin-content-blog/src/authors.ts

Josh-Cena

Do we have tests for local image URLs (like image: ./file.png)? What's the current behavior, for front matter and for authors.yml?

slorber · 2023-11-27T09:26:57Z

image

I don't think we have good tests for that apart dogfooding it on our own website. Now that we expose front matter to remark plugins we can probably provide a better implementation of the "markdown assets" thing, but that's a separate issue to work on

I don't think either we support local images for authors.yml, IMHO local images makes less sense when image is meant to be used on multiple blog posts, and not even sure how to implement it without a new codegen step.

Josh-Cena · 2023-11-27T14:30:11Z

Maybe it's just me but I'm using the static folder less and less—bundling everything seems more organized to me. Even with authors.yml, we should be able to specify an image relative to the yaml file.

argos-ci · 2023-12-05T15:14:44Z

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	🧿 Changes detected (Review)	124 changes	Jan 5, 2024, 6:57 PM

slorber · 2023-12-05T15:34:19Z

Maybe it's just me but I'm using the static folder less and less—bundling everything seems more organized to me. Even with authors.yml, we should be able to specify an image relative to the yaml file.

agree, but we don't really support that currently. That's worth exploring how to implement this in another PR

LGTM thanks @OzakIOne 👍

Co-authored-by: Joshua Chen <sidachen2003@gmail.com> Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com> Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com> Co-authored-by: Ivan Mar (sOkam!) <7308253+heysokam@users.noreply.github.com> Co-authored-by: c0h1b4 <dwidman@gmail.com> Co-authored-by: Janessa Garrow <janessa.garrow@gmail.com> Co-authored-by: ozaki <29860391+OzakIOne@users.noreply.github.com> Co-authored-by: axmmisaka <6500159+axmmisaka@users.noreply.github.com> Co-authored-by: Tatsunori Uchino <tats.u@live.jp> Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com> fix(i18n): complete translations for theme-common.json Brazilian Portuguese (pt-BR) (#9477) fix(content-blog): add baseUrl for author.image_url (#9581) fix(type-aliases): add `title` prop for imported inline SVG React components (#9612) fix(utils): Markdown link replacement with <> but no spaces (#9617) fix(live-codeblock): stabilize react-live transformCode callback, fix editor/preview desync (#9631) fix(cli): output help when no conventional config + no subcommand (#9648) fix CI job (#9604) fix Lint Autofix workflow (#9632) fix(pwa-plugin): upgrade workbox (#9668) fix(create-docusaurus): fix init template code blocks, and little improvements (#9696) fix(theme): allow empty code blocks and live playgrounds (#9704)

Co-authored-by: Joshua Chen <sidachen2003@gmail.com> Co-authored-by: Joey Clover <joey@popos.local> Co-authored-by: reece-white <93522192+reece-white@users.noreply.github.com> Co-authored-by: Shreesh Nautiyal <114166000+Shreesh09@users.noreply.github.com> Co-authored-by: Nick Gerleman <nick@nickgerleman.com> Co-authored-by: Chongyi Zheng <git@zcy.dev> Co-authored-by: MCR Studio <99176216+mcrstudio@users.noreply.github.com> Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com> Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com> Co-authored-by: Ivan Mar (sOkam!) <7308253+heysokam@users.noreply.github.com> Co-authored-by: c0h1b4 <dwidman@gmail.com> Co-authored-by: Janessa Garrow <janessa.garrow@gmail.com> Co-authored-by: ozaki <29860391+OzakIOne@users.noreply.github.com> Co-authored-by: axmmisaka <6500159+axmmisaka@users.noreply.github.com> Co-authored-by: Tatsunori Uchino <tats.u@live.jp> Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com> Co-authored-by: Sanjaiyan Parthipan <parthipankalayini@gmail.com> Co-authored-by: Jack Robson <143492403+jack-robson@users.noreply.github.com> Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com> Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com> fix(create-docusaurus): fix readme docusaurus 2 ref (#9487) fix(theme): fix firefox CSS :has() support bug (#9530) fix(theme): docs html sidebar items should always be visible (#9531) fix: v3 admonitions should support v2 title syntax for nested admonitions (#9535) fix(theme-classic): fixed wrong cursor on dropdown menu in navbar, when window is small (#9398) fix(theme): upgrade prism-react-renderer, fix html script and style tag highlighting (#9567) fix: add v2 retrocompatible support for quoted admonitions (#9570) fix(i18n): complete translations for theme-common.json Brazilian Portuguese (pt-BR) (#9477) fix(content-blog): add baseUrl for author.image_url (#9581) fix(type-aliases): add `title` prop for imported inline SVG React components (#9612) fix(utils): Markdown link replacement with <> but no spaces (#9617) fix(live-codeblock): stabilize react-live transformCode callback, fix editor/preview desync (#9631) fix(cli): output help when no conventional config + no subcommand (#9648) fix CI job (#9604) fix Lint Autofix workflow (#9632) fix(pwa-plugin): upgrade workbox (#9668) fix(create-docusaurus): fix init template code blocks, and little improvements (#9696) fix(theme): allow empty code blocks and live playgrounds (#9704) fix(core): various broken anchor link fixes (#9732) fix: remove old useless mdx typedefs (#9733) fix(theme-common): fix missing code block MagicComments style in Visual Basic (.NET) 16 (#9727) fix(core): conditionally include `hostname` parameter when using… (#9407) fix(create-docusaurus): fix typo in init template sample docs (#9783) fix(mdx-loader): allow spaces before `mdx-code-block` info string (#9776) fix(core): links with target "_blank" should no be checked by the broken link checker (#9788) fix(core): broken links optimization behaves differently than non-optimized logic (#9791)

OzakIOne added 2 commits November 24, 2023 16:10

fix: add baseUrl for author.image_url

0cf55c0

fix: test for legacy front matter

0d0f858

OzakIOne requested review from slorber, lex111 and Josh-Cena as code owners November 24, 2023 15:53

facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 24, 2023

wip: refactor & add tests

59494e0

slorber added pr: bug fix This PR fixes a bug in a past release. to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 26, 2023

slorber requested changes Nov 26, 2023

View reviewed changes

packages/docusaurus-plugin-content-blog/src/authors.ts Outdated Show resolved Hide resolved

packages/docusaurus-plugin-content-blog/src/authors.ts Outdated Show resolved Hide resolved

packages/docusaurus-plugin-content-blog/src/authors.ts Outdated Show resolved Hide resolved

Josh-Cena reviewed Nov 27, 2023

View reviewed changes

wip: refactor review

f008026

slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Dec 5, 2023

slorber approved these changes Dec 5, 2023

View reviewed changes

slorber merged commit 4cc5613 into facebook:main Dec 5, 2023
31 of 32 checks passed

OzakIOne deleted the ozaki/baseurl-author-imageurl branch December 5, 2023 15:39

slorber pushed a commit that referenced this pull request Jan 5, 2024

fix(content-blog): add baseUrl for author.image_url (#9581)

ed758fc

slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 5, 2024

NikolayS mentioned this pull request Apr 24, 2024

[Snyk] Security upgrade @docusaurus/plugin-pwa from 2.0.0-alpha.66 to 3.1.0 NikolayS/docusaurus#200

Open

kenodegard mentioned this pull request May 8, 2024

Conda's Prefixes Blogpost conda-incubator/conda-dot-org#148

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(content-blog): add baseUrl for author.image_url #9581

fix(content-blog): add baseUrl for author.image_url #9581

OzakIOne commented Nov 24, 2023 •

edited

netlify bot commented Nov 24, 2023 •

edited

github-actions bot commented Nov 24, 2023 •

edited

slorber left a comment

Josh-Cena left a comment

slorber commented Nov 27, 2023

Josh-Cena commented Nov 27, 2023

argos-ci bot commented Dec 5, 2023 •

edited

slorber commented Dec 5, 2023

fix(content-blog): add baseUrl for author.image_url #9581

fix(content-blog): add baseUrl for author.image_url #9581

Conversation

OzakIOne commented Nov 24, 2023 • edited

Pre-flight checklist

Motivation

Test Plan

Test links

Related issues/PRs

netlify bot commented Nov 24, 2023 • edited

✅ [V2]

github-actions bot commented Nov 24, 2023 • edited

⚡️ Lighthouse report for the deploy preview of this PR

slorber left a comment

Choose a reason for hiding this comment

Josh-Cena left a comment

Choose a reason for hiding this comment

slorber commented Nov 27, 2023

Josh-Cena commented Nov 27, 2023

argos-ci bot commented Dec 5, 2023 • edited

slorber commented Dec 5, 2023

OzakIOne commented Nov 24, 2023 •

edited

netlify bot commented Nov 24, 2023 •

edited

github-actions bot commented Nov 24, 2023 •

edited

argos-ci bot commented Dec 5, 2023 •

edited