-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): various broken anchor link fixes #9732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nksForPage() failure
This notably allows "#" link on the /404.html page
slorber
added
pr: bug fix
This PR fixes a bug in a past release.
to backport
This PR is planned to be backported to a stable version of Docusaurus
labels
Jan 11, 2024
⚡️ Lighthouse report for the deploy preview of this PR
|
7 tasks
…checker' into slorber/fix-Link-broken-anchors-checker
This was referenced Jun 27, 2024
This was referenced Jul 17, 2024
This was referenced Jul 21, 2024
This was referenced Jul 21, 2024
This was referenced Aug 4, 2024
This was referenced Aug 12, 2024
This was referenced Aug 21, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: bug fix
This PR fixes a bug in a past release.
to backport
This PR is planned to be backported to a stable version of Docusaurus
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix some edge cases in the newly released (v3.1) broken link checker anchor support
Previous implementation did not report broken local anchor links such as
[local link](#local-heading-id)
, among other things. As a result it didn't detect all the broken links we had on our own website.Also fix #9717, edge case related to encoding of the anchor id
MDX elements such as
<li>
(used in footnotes), and<details>
should also collect anchor idsI'll explore making this more automatic in the future but for now it's a good-enough improvement.
Test Plan
unit tests + dogfood
Test links
https://deploy-preview-9732--docusaurus-2.netlify.app/