-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make iOS 9 compatible again. #874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
I see that the cause of the build failure on master that I mentioned has already been fixed 9878220 |
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin/descriptors/SKViewDescriptor.mm
Outdated
Show resolved
Hide resolved
d2ae58c
to
16ca010
Compare
@alloy has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
FlipperKit 0.33.1 contains facebook/flipper#874 and is also compatible with the next react-native-flipper version
…pper (#28277) Summary: This pull request re-applies #28225, thereby reverting 4bb1794, this time bumping to FlipperKit 0.33.1 which is again compatible with iOS 9 (thanks to facebook/flipper#874) This is the iOS counterpart of #28275 ## Changelog [iOS] [Changed] - Upgrade Flipper dependency to 0.33.1 Pull Request resolved: #28277 Test Plan: * Bumped the version in our Flipper / RN integration test app first, that runs on 0.62-rc.5, verified everything still works there. * CI ![Screen Shot 2020-03-10 at 12 12 46](https://user-images.githubusercontent.com/1820292/76311312-94f09f00-62c8-11ea-81db-ced6d16e096b.png) Reviewed By: mweststrate Differential Revision: D20369106 Pulled By: TheSavior fbshipit-source-id: dfeb0446e7f29684a266eca5d0e29ac42cef2ef3
…pper (#28277) Summary: This pull request re-applies #28225, thereby reverting 4bb1794, this time bumping to FlipperKit 0.33.1 which is again compatible with iOS 9 (thanks to facebook/flipper#874) This is the iOS counterpart of #28275 [iOS] [Changed] - Upgrade Flipper dependency to 0.33.1 Pull Request resolved: #28277 Test Plan: * Bumped the version in our Flipper / RN integration test app first, that runs on 0.62-rc.5, verified everything still works there. * CI ![Screen Shot 2020-03-10 at 12 12 46](https://user-images.githubusercontent.com/1820292/76311312-94f09f00-62c8-11ea-81db-ced6d16e096b.png) Reviewed By: mweststrate Differential Revision: D20369106 Pulled By: TheSavior fbshipit-source-id: dfeb0446e7f29684a266eca5d0e29ac42cef2ef3
Summary
React Native v0.62.0’s template still uses iOS 9 as deployment target, bumping it to 10 this late in the release cycle is probably not a good idea, so instead I made this tiny change to make it iOS 9 compatible again.
v0.32.2
tag, asmaster
was giving me a build failure and in any case it would be better to release just this change as a patch release so the RNv0.62.0-rc.3
release can go out without having to test Flipper as thoroughly again.Changelog
Make FlipperKit compatible with iOS 9 again.
Test Plan
pod install
with a Podfile that has iOS 9 as its deployment target passes again.v0.62.0-rc.3
template works.