Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm module? #26

Closed
dolphin278 opened this issue Nov 18, 2014 · 5 comments · Fixed by #68
Closed

npm module? #26

dolphin278 opened this issue Nov 18, 2014 · 5 comments · Fixed by #68

Comments

@dolphin278
Copy link

Will you publish it to npm?

@dolphin278
Copy link
Author

Oh, sorry, misread languages used with facebook/immutable-js opened in next tab.

Sorry, that was stupid question :)

@gabelevi
Copy link
Contributor

From our limited investigation, publishing binaries through npm seems a little awkward. We've come up with a few approaches, but decided to punt on it for now since they don't seem to make things easier. The approaches were:

  1. Create a package for each OS that needs it's own package. So flow-mac & flow-debian ...
  2. Create a single package with an install script that looks at the platform and fetches the correct binary
  3. Create a single package with the source that then compiles it

While we might publish to npm eventually, we decided to hold off for now.

Leaving this issue open for now in case other people are wondering the same question.

@sophiebits
Copy link
Contributor

I haven't looked at how they do it, but I think the phantomjs package downloads binaries.

@tcoopman
Copy link
Contributor

@kevva
Copy link

kevva commented Nov 19, 2014

@gabelevi, you should add a note about the flow-bin package in the readme.

@spicyj, yeah, but in a pretty excessive way. I've created a module for exactly this purpose (kevva/bin-wrapper).

stevemao added a commit to stevemao/flow that referenced this issue Nov 19, 2014
stevemao added a commit to stevemao/flow that referenced this issue Nov 19, 2014
stevemao added a commit to stevemao/flow that referenced this issue Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants