Clang fixes #2905
Closed
Clang fixes #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strange check for this has been broken since October last year, it seems when the callback type was changed to take a `const char*` instead of `char*`. This probably works ok in GCC, but fails in clang because it doesn't coerce the `char*` to `const char*`.
For some reason this causes clang to be unable to find various standard headers.
|
Your changes with Dwarf will break compiling with libdwarf 20130729 and later versions, I think. Also, I'm pretty sure, I have been able to successfully compile using Clang with this LIBDWARF_CALLBACK_NAME_TYPE. But I can test that later. See also #1490. |
|
@kristapsk I'm using libdwarf from April 2014. The change was made in October last year, which I mention in my commit message. |
|
Ok, the dwarf error happens on GCC as well. |
|
My mistake - your changes would actually break compiling with libdwarf older than 20130729. :) That change in October was made to support both 20120410 and 20130729, where incompatible changes were introduced (see http://www.prevanders.net/dwarf.html#const). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple fixes for compilation errors I found using clang.