Fix test results CI path on Windows #6585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moughxyz
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
ivailop7
approved these changes
Sep 3, 2024
etrepum
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
I also don't know why it was done this way originally. I did refactor it, but this path is from the whoever implemented it before. I don't currently have access to a windows machine to test this, but it couldn't hurt to try since we know the current setting is incorrect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playwright test results on Windows are not being uploaded to GitHub artifacts when a test fails.
It was refactored here: #6029
You can see examples of failed tests not uploading the .webm files here:
The playwright run log shows it's saving the video to
test-results/and not~/.npm/_logs/Video results do get uploaded correctly on non-Windows failures.
Ultimately I can't be sure this is the correct fix since I imagine I don't have permission to run modified workflows, but hoping to open this up to someone that may know better what's going on (cc @etrepum).