[lexical-table] Bug: Table formatting and styling not persisting for empty cells #6626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatsiarynaDzibrova
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
etrepum
reviewed
Sep 12, 2024
Comment on lines
1194
to
1199
| selectedNodes.forEach((node) => { | ||
| if ($isParagraphNode(node)) { | ||
| const newFormat = node.getFormatFlags(formatType, null); | ||
| node.setTextFormat(newFormat); | ||
| } | ||
| }); |
There was a problem hiding this comment.
We should implement alignment with the first cell of the selection. When the text/paragraphs have mixed formatting toggling bold should change the entire selection to have the same setting for bold.
Screen.Recording.2024-09-12.at.11.49.27.mov
| @@ -357,7 +357,7 @@ export class TableObserver { | |||
| const focus = formatSelection.focus; | |||
|
|
|||
| selection.getNodes().forEach((cellNode) => { | |||
There was a problem hiding this comment.
I think this is where we would have to capture the format alignment
Aligns format between different cells of the table for tableSelection. Get the format for the first cell and pass it to formatText function to allign all the next cells with it.
…the first TextNode
etrepum
previously approved these changes
Sep 13, 2024
etrepum
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply format change to empty paragraphs. Before it was only applied to text nodes
Closes #6583
Test plan
Before
Formatting is not applied to empty paragraphs
After
Formatting is applied to empty paragraphs
