Add LibUnwind as a dependency of glog::glog #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: GitHub commits: facebook/CacheLib@6fb2cea facebook/fb303@42bae2e facebook/fbthrift@415b4b8 facebook/proxygen@baf28ee facebook/wangle@b47ab7f facebook/watchman@67abe66 facebookexperimental/edencommon@3a53266 facebookincubator/fizz@65841f2 facebookincubator/katran@04dd581 facebook@6ce5fee facebookincubator/velox@11270c9 Reviewed By: wittgenst fbshipit-source-id: 9df4bdbdcfa383305a2833cb2a212a18d80a1397
Summary: GitHub commits: facebook/fbthrift@d818250 facebookincubator/fizz@61a5fce Reviewed By: wittgenst fbshipit-source-id: 41a45ba7840adaacf8e22328217be9dd6c2f45e7
Summary:
This fixes the following OSS Linux build failure:
```
mvfst/include/quic/dsr/test/Mocks.h:21:3: required from here
/usr/include/c++/8/type_traits:1288:12: error: invalid use of incomplete type ‘struct quic::SendInstruction’
struct is_base_of
^~~~~~~~~~
In file included from mvfst/include/quic/state/StreamData.h:14,
from mvfst/include/quic/state/QuicStreamManager.h:15,
from mvfst/include/quic/state/StateData.h:30,
from mvfst/include/quic/api/QuicSocket.h:22,
from proxygen/proxygen/lib/http/session/HQByteEventTracker.h:12,
from proxygen/proxygen/lib/http/session/HQSession.h:26,
from proxygen/proxygen/lib/http/session/test/HQSessionMocks.h:13,
from proxygen/proxygen/lib/http/session/test/HQUpstreamSessionTest.h:19,
from proxygen/proxygen/lib/http/session/test/HQUpstreamSessionTest.cpp:9:
mvfst/include/quic/dsr/DSRPacketizationRequestSender.h:12:8: note: forward declaration of ‘struct quic::SendInstruction’
struct SendInstruction;
^~~~~~~~~~~~~~~
In file included from folly/include/folly/Optional.h:68,
from folly/include/folly/futures/Future.h:27,
from proxygen/proxygen/lib/http/session/test/HQUpstreamSessionTest.h:9,
from proxygen/proxygen/lib/http/session/test/HQUpstreamSessionTest.cpp:9:
```
Reviewed By: mjoras
Differential Revision: D38280556
fbshipit-source-id: 3b2ed81813dd0fa386dcffe7c5f2e67fe55bc153
Summary: GitHub commits: facebook/folly@4b93094 facebook/proxygen@c2d58e3 facebook/rocksdb@1aab5b3 facebook@cf97766 Reviewed By: wittgenst fbshipit-source-id: 444e3a49343e802d0e0bca1c8e1991002286cf90
Summary: GitHub commits: facebook/CacheLib@6f5872d facebook/fb303@22cbe34 facebook/fbthrift@0f0ef1f facebook/folly@9761765 facebook/proxygen@f055f12 facebook/wangle@09384ee facebook/watchman@0cecee3 facebookexperimental/edencommon@544b0f6 facebookincubator/fizz@2e21bcf facebookincubator/katran@f58f9e4 facebook@7dbd670 facebookincubator/velox@95fb425 Reviewed By: wittgenst fbshipit-source-id: aa3d3dc8d1a5cbc8153f585da4cf0802573432e3
Summary: GitHub commits: facebook/CacheLib@04879bc facebook/fb303@9c9cff8 facebook/fbthrift@02aee68 facebook/proxygen@fffe104 facebook/wangle@aeba000 facebook/watchman@49cbd09 facebookexperimental/edencommon@f8342bd facebookexperimental/rust-shed@310d16a facebookincubator/fizz@50a02cb facebookincubator/katran@053bd15 facebook@516c54e facebookincubator/velox@c78b680 facebookresearch/beanmachine@43e2ad7 Reviewed By: wittgenst fbshipit-source-id: 088a5b2ee4df0a6df14ba0408a459ea12b139404
Summary: GitHub commits: facebook/CacheLib@7f3bfbb facebook/fb303@5e3b981 facebook/fbthrift@1b691a3 facebook/folly@a0388fd facebook/proxygen@b00f8c1 facebook/wangle@6d627ee facebook/watchman@d5da829 facebookexperimental/rust-shed@cf35dc1 facebookincubator/katran@b038488 facebook@b3a177b facebookresearch/beanmachine@f86c28f Reviewed By: wittgenst fbshipit-source-id: ab7c583a5f69bb1901424f58277980737120e980
Summary: GitHub commits: facebook/CacheLib@f97b421 facebook/fb303@5958eac facebook/fbthrift@326973e facebook/litho@eabc1ae facebook/proxygen@79ed818 facebook/wangle@0ca5a0f facebook/watchman@d7f8969 facebookexperimental/edencommon@fefbd7a facebookexperimental/rust-shed@5fe0af9 facebookincubator/fizz@33cbeb3 facebookincubator/katran@4071398 facebook@ac4cec8 facebookincubator/velox@16c9f42 Reviewed By: wittgenst fbshipit-source-id: 61219307034e7fef400717207c9f8e522f5f536e
Summary: GitHub commits: facebook/CacheLib@4a2a5a1 facebook/fb303@b251dae facebook/fbthrift@d6a0d1c facebook/folly@7ee8c78 facebook/proxygen@85db1a4 facebook/rocksdb@54aebb2 facebook/wangle@d3cd193 facebook/watchman@fd910ab facebookexperimental/rust-shed@0583686 facebookincubator/katran@6bfda06 facebook@24f9f37 facebookincubator/velox@13db811 Reviewed By: wittgenst fbshipit-source-id: da66692cfd5227eab750d45d217343ac2453c161
Summary: GitHub commits: facebook/CacheLib@449b7c2 facebook/fb303@46aed5b facebook/fbthrift@b62475a facebook/proxygen@4be524d facebook/wangle@b95c957 facebook/watchman@3e7d331 facebookexperimental/edencommon@af67692 facebookexperimental/rust-shed@ab7727b facebookincubator/fizz@9798755 facebookincubator/katran@622f9c8 facebook@94e1fc0 facebookincubator/velox@a96de7e Reviewed By: wittgenst fbshipit-source-id: c60317c63645d7f6d5866440467210f94a261dc1
Summary: GitHub commits: facebook/fbthrift@811f038 facebook/folly@701f160 facebook/litho@7e77242 facebookexperimental/rust-shed@e219085 Reviewed By: bigfootjon fbshipit-source-id: b70e431c54314f6d6006ae4fee377b3296283b1d
Summary: GitHub commits: facebook/CacheLib@54f098f facebook/fb303@9c11d4c facebook/fbthrift@5299b32 facebook/litho@1113c27 facebook/proxygen@ea3fe0a facebook/wangle@06e9316 facebook/watchman@3ea6385 facebookexperimental/edencommon@89c14fb facebookexperimental/rust-shed@7f579dd facebookincubator/fizz@450aa2e facebookincubator/katran@b1837b7 facebook@2adb54c facebookincubator/velox@0422349 facebookresearch/multimodal@5457c30 Reviewed By: bigfootjon fbshipit-source-id: 3da2aa75a31af7b0ca145ee333de35b8a60e6199
Summary: GitHub commits: facebook/CacheLib@c580fdd facebook/fb303@05059cd facebook/fbthrift@0e5882a facebook/folly@b93164d facebook/proxygen@36f5a17 facebook/wangle@dfc5ef2 facebook/watchman@bf225ba facebookexperimental/rust-shed@76ae7d3 facebookincubator/katran@d4a7f1a facebook@b53f3bc Reviewed By: bigfootjon fbshipit-source-id: ca6c98af387c25ee0a5ec539232eb867983dc111
Summary: X-link: facebookresearch/Private-ID#71 Previous codemod left some crust. This commit cleans up useless uses to use less uses. Reviewed By: stepancheg Differential Revision: D38211793 fbshipit-source-id: c852dd1ec617fe81a1d9bd0d8a9e5d2357b9b502
) Summary: Bumps [cross-fetch](https://github.com/lquixada/cross-fetch) from 3.1.4 to 3.1.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lquixada/cross-fetch/releases">cross-fetch's releases</a>.</em></p> <blockquote> <h2>v3.1.5</h2> <h2>What's Changed</h2> <ul> <li>chore: updated node-fetch version to 2.6.7 by <a href="https://github.com/dlafreniere"><code>@dlafreniere</code></a> in <a href="https://github-redirect.dependabot.com/lquixada/cross-fetch/pull/124">lquixada/cross-fetch#124</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/dlafreniere"><code>@dlafreniere</code></a> made their first contribution in <a href="https://github-redirect.dependabot.com/lquixada/cross-fetch/pull/124">lquixada/cross-fetch#124</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/lquixada/cross-fetch/compare/v3.1.4...v3.1.5">https://github.com/lquixada/cross-fetch/compare/v3.1.4...v3.1.5</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lquixada/cross-fetch/commit/c6089dfafc1fd6253b4d204d37c0439eea631cd0"><code>c6089df</code></a> chore(release): 3.1.5</li> <li><a href="https://github.com/lquixada/cross-fetch/commit/a3b3a9481091ddd06b8f83784ba9c4e034dc912a"><code>a3b3a94</code></a> chore: updated node-fetch version to 2.6.7 (<a href="https://github-redirect.dependabot.com/lquixada/cross-fetch/issues/124">https://github.com/facebookincubator/mvfst/issues/124</a>)</li> <li><a href="https://github.com/lquixada/cross-fetch/commit/efed703489d591eee76a15d12b088538d04f668b"><code>efed703</code></a> chore: updated node-fetch version to 2.6.5</li> <li><a href="https://github.com/lquixada/cross-fetch/commit/694ff77b367cff4be7e16366988b394016717e88"><code>694ff77</code></a> refactor: removed ora from dependencies</li> <li><a href="https://github.com/lquixada/cross-fetch/commit/efc5956f740440cf4684e982fd4ceef85f2a2c67"><code>efc5956</code></a> refactor: added .vscode to .gitignore</li> <li><a href="https://github.com/lquixada/cross-fetch/commit/da605d5ab026e7986f6633307fbd3018f1eebb58"><code>da605d5</code></a> refactor: renamed test/fetch/ to test/fetch-api/ and test/module/ to test/mod...</li> <li><a href="https://github.com/lquixada/cross-fetch/commit/0f0d51de7f07f5202ee9de472d88c71911da9cb9"><code>0f0d51d</code></a> chore: updated minor and patch versions of dev dependencies</li> <li><a href="https://github.com/lquixada/cross-fetch/commit/c6e34ead1bb70845eccf9ec83c3144ccf4a73f2e"><code>c6e34ea</code></a> refactor: removed sinon.js</li> <li><a href="https://github.com/lquixada/cross-fetch/commit/f524a522ecda60db99f57798beac8e7af3349580"><code>f524a52</code></a> fix: yargs was incompatible with node 10</li> <li><a href="https://github.com/lquixada/cross-fetch/commit/7906fcf4c2d3fa300690baa72dc6b8fa30ac02ea"><code>7906fcf</code></a> chore: updated dev dependencies</li> <li>Additional commits viewable in <a href="https://github.com/lquixada/cross-fetch/compare/v3.1.4...v3.1.5">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `dependabot rebase` will rebase this PR - `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `dependabot merge` will merge this PR after your CI passes on it - `dependabot squash and merge` will squash and merge this PR after your CI passes on it - `dependabot cancel merge` will cancel a previously requested merge and block automerging - `dependabot reopen` will reopen this PR if it is closed - `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebookincubator/mvfst/network/alerts). </details> Pull Request resolved: facebook#250 Test Plan: Imported from GitHub, without a `Test Plan:` line. **Static Docs Preview: mvfst** |[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D36083164/V4/mvfst/)| |**Modified Pages**| Reviewed By: mjoras, lnicco Differential Revision: D36083164 Pulled By: jbeshay fbshipit-source-id: cfc9338237cb1b3b1e7c6f085b02e52f8bb7eeca
Summary: GitHub commits: facebook/CacheLib@a8ef988 facebook/fb303@a9abca5 facebook/fbthrift@109b081 facebook/folly@8205765 facebook/proxygen@0e8e302 facebook/rocksdb@e1b176d facebook/wangle@b46dc1a facebook/watchman@3754e79 facebookexperimental/edencommon@28db2f3 facebookexperimental/rust-shed@e615695 facebookincubator/fizz@6b18d27 facebookincubator/katran@483bd0b facebook@1e358c5 facebookincubator/velox@66f9686 pytorch/kineto@0a2af89 Reviewed By: bigfootjon fbshipit-source-id: 57c728394476fe8db3dc1e8d09b80287b2cfc565
Summary: GitHub commits: facebook/CacheLib@2e0e5fe facebook/fb303@3d36761 facebook/fbthrift@72eefae facebook/proxygen@81cb6cc facebook/wangle@65e41e7 facebook/watchman@4b64719 facebookexperimental/edencommon@938fbcd facebookexperimental/rust-shed@5ca0485 facebookincubator/fizz@1462b5e facebookincubator/katran@34153c6 facebook@5c8b672 facebookincubator/velox@ab38fb4 Reviewed By: bigfootjon fbshipit-source-id: 1db9b34ce8e203424ee011112692da6efbb96dfa
Summary: GitHub commits: facebook/CacheLib@c0f9467 facebook/fb303@cab234e facebook/fbthrift@635d054 facebook/folly@47896bc facebook/proxygen@d76de69 facebook/wangle@2c14287 facebook/watchman@ee1258d facebookexperimental/rust-shed@4a9c0fa facebookincubator/katran@fecb8d0 facebook@863a0c3 facebookincubator/velox@ae7aaf4 facebookresearch/beanmachine@4e430a2 facebookresearch/FLSim@b60f3de Reviewed By: bigfootjon fbshipit-source-id: 4ecbf4ae261606092241ac71877f465c3e1c821f
Summary: GitHub commits: facebook/CacheLib@d54908b facebook/fb303@35cb93f facebook/fbthrift@fd9fc98 facebook/proxygen@5377d36 facebook/wangle@0a85844 facebook/watchman@7e28293 facebookexperimental/edencommon@411f139 facebookexperimental/rust-shed@ebb52ee facebookincubator/fizz@0d54aef facebookincubator/katran@6b542b1 facebook@8424533 facebookincubator/velox@0b99315 Reviewed By: bigfootjon fbshipit-source-id: 8143bb93a8056dd606906b227264d3c182a73ea5
Summary: GitHub commits: facebook/CacheLib@025ec39 facebook/fb303@6a47035 facebook/fbthrift@ddf8d09 facebook/folly@256f284 facebook/watchman@7259579 facebookexperimental/rust-shed@0be3637 Reviewed By: bigfootjon fbshipit-source-id: 1d342494ea8773a2307547fecb7afac03078663c
Summary: GitHub commits: facebook/CacheLib@8dd9bbb facebook/fb303@664e4ba facebook/fbthrift@b0e7210 facebook/litho@2279bdc facebook/proxygen@b1b385b facebook/wangle@bb6941a facebook/watchman@cd8835c facebookexperimental/edencommon@0c34257 facebookexperimental/rust-shed@d097f83 facebookincubator/fizz@53a545b facebookincubator/katran@1af436a facebook@0e71bf7 facebookincubator/velox@8496420 Reviewed By: bigfootjon fbshipit-source-id: f1ee3243cc62635c26b28793192766459394e995
Summary: GitHub commits: facebook/CacheLib@9f8ca7f facebook/fb303@c565acb facebook/folly@a575638 facebook/watchman@37604f6 facebookexperimental/rust-shed@0025e2f Reviewed By: bigfootjon fbshipit-source-id: d10430f9a79f2b8ccb0bb5406025057c3ff63cbc
Summary: GitHub commits: facebook/CacheLib@1e40e7e facebook/fb303@a7b82a1 facebook/fbthrift@39b6a73 facebook/litho@af5495b facebook/proxygen@f72180f facebook/wangle@2141f80 facebook/watchman@46c4e43 facebookexperimental/edencommon@fba4080 facebookincubator/fizz@fe0393b facebookincubator/katran@d92ce89 facebook@cbdaf5a facebookincubator/velox@e43ba5e Reviewed By: bigfootjon fbshipit-source-id: 56c6f2606524598cdd4aaf2853e6d5a9adefb3bc
Summary: support multishot recvmsg in quic worker Differential Revision: D37921703 fbshipit-source-id: c8b749b40895fe961adc6b9929bbcc0345fff029
Summary: we can do this as the event base stays on 1 thread Differential Revision: D37921701 fbshipit-source-id: f6d29c7b29a93425968b86370b29449a091ad4a3
Summary: GitHub commits: facebook/folly@062daf4 facebook/litho@5fdc111 facebook/proxygen@0b38c9e Reviewed By: bigfootjon fbshipit-source-id: d40fd728a44d6d3043c74fb2bb55b4399d4e6248
Summary: GitHub commits: facebook/CacheLib@b7653e8 facebook/fb303@d20a679 facebook/fbthrift@5a3af4f facebook/proxygen@a93917b facebook/wangle@d821f00 facebook/watchman@92530e0 facebookexperimental/edencommon@e2272bf facebookincubator/fizz@02acee3 facebookincubator/katran@3b903f7 facebook@69eab84 facebookincubator/velox@55261d8 Reviewed By: bigfootjon fbshipit-source-id: ef611870b95289f5f73235c3672c67d7f850953c
Summary: GitHub commits: facebook/CacheLib@94d718f facebook/fb303@07764dd facebook/fbthrift@a98af93 facebook/folly@46bb62c facebook/rocksdb@bef3127 facebook/watchman@ba781e8 facebookexperimental/rust-shed@ac4f992 facebookincubator/velox@288ba8a facebookresearch/beanmachine@f13a4c3 facebookresearch/FLSim@36f6d47 pytorch/FBGEMM@499cd22 Reviewed By: bigfootjon fbshipit-source-id: 6770fb46c33f8437cf821384a85dcce01a9afef9
Summary: GitHub commits: facebook/CacheLib@b184a01 facebook/fb303@ef6ebd0 facebook/fbthrift@631cfee facebook/proxygen@8007dc4 facebook/rocksdb@8d664cc facebook/wangle@585b7e3 facebook/watchman@838b5bf facebookexperimental/edencommon@724ed48 facebookexperimental/rust-shed@43762e4 facebookincubator/fizz@3554e1b facebookincubator/katran@7ca8280 facebook@5262d1b facebookincubator/velox@950a7ce pytorch/FBGEMM@5160e7d pytorch/multipy@bd528d0 Reviewed By: bigfootjon fbshipit-source-id: f38ffa919a8b56a5b3aa0e63c490893a832f6239
Summary: GitHub commits: facebook/CacheLib@526f9be facebook/fb303@728a5e8 facebook/folly@3fd5687 facebook/proxygen@5809556 facebook/watchman@39fa454 facebookexperimental/rust-shed@a54402d Reviewed By: bigfootjon fbshipit-source-id: f759a075667678755c4430963f871e11a71ef6c7
Atry
added a commit
to Atry/fboss
that referenced
this pull request
Sep 8, 2022
Summary: X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Differential Revision: D39340650 fbshipit-source-id: 653cf4c5b8f27fbb2ca8aebbb3a30b092479deca
Atry
added a commit
to Atry/openr
that referenced
this pull request
Sep 8, 2022
Summary: X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Differential Revision: D39340650 fbshipit-source-id: 3ada6cf92d47e40ca86d2b346a46f7dae310556b
Atry
added a commit
to Atry/hhvm
that referenced
this pull request
Sep 8, 2022
Summary: X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Differential Revision: D39340650 fbshipit-source-id: 79ef80a08de016463d6197276b3e1222da28bec3
This was referenced Sep 8, 2022
Atry
added a commit
to Atry/folly
that referenced
this pull request
Sep 8, 2022
Summary: X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Differential Revision: D39340650 fbshipit-source-id: 30ca943999e305dc5e8513976d1f80f90f43a212
|
Hi @Atry! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
yfeldblum
added a commit
to yfeldblum/folly
that referenced
this pull request
Jan 13, 2023
Summary: Pull Request resolved: facebook#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Differential Revision: D42509278 fbshipit-source-id: 6cda642a111ee463b928d083ef4849472ca43a46
yfeldblum
added a commit
to yfeldblum/folly
that referenced
this pull request
May 17, 2023
Summary: Pull Request resolved: facebook#1916 Pull Request resolved: facebook#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: 79aa2e3d06b0d4f3b60ab4e9f46e51de214e8041
yfeldblum
added a commit
to yfeldblum/folly
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#1916 Pull Request resolved: facebook#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: 47db28bacea510e8b8f8e556c1ae86dce29e6d91
facebook-github-bot
force-pushed
the
main
branch
from
0ab877e
to
888ff7d
Compare
yfeldblum
added a commit
to yfeldblum/folly
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 Pull Request resolved: #32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 Pull Request resolved: #5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 Pull Request resolved: #524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 Pull Request resolved: #209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 Pull Request resolved: #82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 Pull Request resolved: #101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 Pull Request resolved: #35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 Pull Request resolved: #1916 Pull Request resolved: #1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 Pull Request resolved: #429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 Pull Request resolved: #141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 Pull Request resolved: #1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: #128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: #273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 Pull Request resolved: #119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 Pull Request resolved: #9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Apr 2, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 Pull Request resolved: #172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
LibUnwindis a dependency ofglogaccording to objdump. This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported libraryglog::glogas an element in theIMPORTED_LINK_INTERFACE_LIBRARIESproperty.Without this diff, there will be a linker error like this:
Differential Revision: D39340650