Add LibUnwind as a dependency of glog::glog (#101) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Differential Revision: D39340650 fbshipit-source-id: 28d9a494e97ca140b627e02a76e15b3a18199559
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39340650 |
This was referenced Sep 8, 2022
Atry
added a commit
to Atry/fb303
that referenced
this pull request
Sep 8, 2022
Summary: X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Differential Revision: D39340650 fbshipit-source-id: dafa61dcf2d4ce8957c2999186d697fefe140238
Atry
added a commit
to Atry/fboss
that referenced
this pull request
Sep 8, 2022
Summary: X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Differential Revision: D39340650 fbshipit-source-id: 653cf4c5b8f27fbb2ca8aebbb3a30b092479deca
Atry
added a commit
to Atry/openr
that referenced
this pull request
Sep 8, 2022
Summary: X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Differential Revision: D39340650 fbshipit-source-id: 3ada6cf92d47e40ca86d2b346a46f7dae310556b
Atry
added a commit
to Atry/hhvm
that referenced
this pull request
Sep 8, 2022
Summary: X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Differential Revision: D39340650 fbshipit-source-id: 79ef80a08de016463d6197276b3e1222da28bec3
This was referenced Sep 8, 2022
Atry
added a commit
to Atry/folly
that referenced
this pull request
Sep 8, 2022
Summary: X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Differential Revision: D39340650 fbshipit-source-id: 30ca943999e305dc5e8513976d1f80f90f43a212
|
Hi @Atry! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
yfeldblum
added a commit
to yfeldblum/folly
that referenced
this pull request
Jan 13, 2023
Summary: Pull Request resolved: facebook#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Differential Revision: D42509278 fbshipit-source-id: 6cda642a111ee463b928d083ef4849472ca43a46
yfeldblum
added a commit
to yfeldblum/folly
that referenced
this pull request
May 17, 2023
Summary: Pull Request resolved: facebook#1916 Pull Request resolved: facebook#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: 79aa2e3d06b0d4f3b60ab4e9f46e51de214e8041
yfeldblum
added a commit
to yfeldblum/folly
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#1916 Pull Request resolved: facebook#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: 47db28bacea510e8b8f8e556c1ae86dce29e6d91
yfeldblum
added a commit
to yfeldblum/folly
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 Pull Request resolved: #32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 Pull Request resolved: #524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 Pull Request resolved: #209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
|
This pull request has been merged in 00a0edb. |
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 Pull Request resolved: #82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 Pull Request resolved: #101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 Pull Request resolved: #35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 Pull Request resolved: #1916 Pull Request resolved: #1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 Pull Request resolved: #429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 Pull Request resolved: #141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 Pull Request resolved: #1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: #128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: #273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 Pull Request resolved: #119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Mar 25, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 Pull Request resolved: #9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 X-link: facebookincubator/katran#172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Apr 2, 2024
Summary: X-link: facebookincubator/zstrong#738 X-link: facebook/folly#1916 X-link: facebook/folly#1857 X-link: facebook/hhvm#9179 X-link: facebook/fboss#119 X-link: facebook/fb303#32 X-link: facebook/openr#141 X-link: facebook/fbthrift#524 X-link: facebook/wangle#209 X-link: facebook/proxygen#429 X-link: facebook/sapling#128 X-link: facebookexperimental/rust-shed#35 X-link: facebook/watchman#1058 X-link: facebookincubator/reindeer#5 X-link: facebookarchive/sapling-staging#8 X-link: facebookexperimental/edencommon#5 X-link: facebookincubator/fizz#82 X-link: facebookincubator/velox#2487 X-link: facebookincubator/hsthrift#101 Pull Request resolved: #172 X-link: facebook/mvfst#273 X-link: https://github.com/fairinternal/AIRStore/pull/38 `LibUnwind` is a dependency of `glog` according to [objdump](https://www.internalfb.com/intern/skycastle/run/117093590319624253/artifact/actionlog.117093590478433674.stdout). This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library `glog::glog` as an element in the `IMPORTED_LINK_INTERFACE_LIBRARIES` property. Without this diff, there will be a linker error like this: ``` /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext' //usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status ``` Reviewed By: Wilfred Differential Revision: D42509278 fbshipit-source-id: ea80449ccc6b91d658bbe9cee954fc8a4a17926f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookincubator/hsthrift#101
X-link: facebookincubator/katran#172
X-link: facebook/mvfst#273
X-link: https://github.com/fairinternal/AIRStore/pull/38
LibUnwindis a dependency ofglogaccording to objdump. This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported libraryglog::glogas an element in theIMPORTED_LINK_INTERFACE_LIBRARIESproperty.Without this diff, there will be a linker error like this:
Differential Revision: D39340650