Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RQG alter_online test fails when checksum is enabled #239

Closed
yoshinorim opened this issue May 2, 2016 · 1 comment
Closed

RQG alter_online test fails when checksum is enabled #239

yoshinorim opened this issue May 2, 2016 · 1 comment
Assignees
@alxyang
Labels
bug myrocks

Comments

@yoshinorim
Copy link
Contributor

How to repeat:
Add checksum config in my.cnf

loose-rocksdb_store_checksums=1
loose-rocksdb_verify_checksums=1
loose-rocksdb_checksums_pct=5

Then run bunch of alter statements -- https://gist.github.com/yoshinorim/8c6a3f55d08133a061a8ac1761ecb2bc

The last alter failed like this:

mysql> ALTER TABLE t1 CHANGE COLUMN extra col3 INT;
ERROR 1030 (HY000): Got error 122 from storage engine

Not sure why, but "reader->m_len" was 4 ha_rocksdb.cc:3610, and it returned HA_ERR_INTERNAL_ERROR.

    if (reader.remaining_bytes())
      return HA_ERR_INTERNAL_ERROR;
@yoshinorim
Copy link
Contributor Author

The error did not happen when checksum was disabled.

@alxyang alxyang self-assigned this May 2, 2016
@alxyang alxyang closed this as completed in c35c6c8 May 4, 2016
@alxyang alxyang mentioned this issue May 4, 2016
Closed
george-lorch pushed a commit to george-lorch/percona-server that referenced this issue May 7, 2016
@alxyang
change check_if_supported_inplace_alter to use guard clause to preven…
e1d53c7 
…t inplace alter on operations that are not yet supported

Summary:
When dropping a column on a table, if that column is also part of an SK, the
inplace drop alter code is triggered to drop the SK.  The inplace alter code
does not have the implementation to handle drop column yet.

Similarly when executing a statement which both DROPS and ADDS an index in the same statement, an online alter would be attempted, but the ADD index functionality is not supported yet, causing assertion fail in MyRocks.

Workaround is to only do inplace alter when the operation is a DROP INDEX on secondary key by itself, and not combined with other operations which arent supported yet.

Fixes facebook/mysql-5.6#239

Squash with D54777

Test Plan: Added new test cases to drop_index_inplace that reproduces the issue

Reviewers: hermanlee4, yoshinorim

Reviewed By: yoshinorim

Subscribers: webscalesql-eng

Differential Revision: https://reviews.facebook.net/D57585
george-lorch pushed a commit to george-lorch/percona-server that referenced this issue May 7, 2016
@alxyang
change check_if_supported_inplace_alter to use guard clause to preven…
205bcc0 
…t inplace alter on operations that are not yet supported

Summary:
When dropping a column on a table, if that column is also part of an SK, the
inplace drop alter code is triggered to drop the SK.  The inplace alter code
does not have the implementation to handle drop column yet.

Similarly when executing a statement which both DROPS and ADDS an index in the same statement, an online alter would be attempted, but the ADD index functionality is not supported yet, causing assertion fail in MyRocks.

Workaround is to only do inplace alter when the operation is a DROP INDEX on secondary key by itself, and not combined with other operations which arent supported yet.

Fixes facebook/mysql-5.6#239

Squash with D54777

Test Plan: Added new test cases to drop_index_inplace that reproduces the issue

Reviewers: hermanlee4, yoshinorim

Reviewed By: yoshinorim

Subscribers: webscalesql-eng

Differential Revision: https://reviews.facebook.net/D57585
george-lorch pushed a commit to george-lorch/percona-server that referenced this issue May 9, 2016
@alxyang
change check_if_supported_inplace_alter to use guard clause to preven…
5187dd7 
…t inplace alter on operations that are not yet supported

Summary:
When dropping a column on a table, if that column is also part of an SK, the
inplace drop alter code is triggered to drop the SK.  The inplace alter code
does not have the implementation to handle drop column yet.

Similarly when executing a statement which both DROPS and ADDS an index in the same statement, an online alter would be attempted, but the ADD index functionality is not supported yet, causing assertion fail in MyRocks.

Workaround is to only do inplace alter when the operation is a DROP INDEX on secondary key by itself, and not combined with other operations which arent supported yet.

Fixes facebook/mysql-5.6#239

Squash with D54777

Test Plan: Added new test cases to drop_index_inplace that reproduces the issue

Reviewers: hermanlee4, yoshinorim

Reviewed By: yoshinorim

Subscribers: webscalesql-eng

Differential Revision: https://reviews.facebook.net/D57585
george-lorch pushed a commit to george-lorch/percona-server that referenced this issue May 9, 2016
@alxyang
change check_if_supported_inplace_alter to use guard clause to preven…
f0b5c68 
…t inplace alter on operations that are not yet supported

Summary:
When dropping a column on a table, if that column is also part of an SK, the
inplace drop alter code is triggered to drop the SK.  The inplace alter code
does not have the implementation to handle drop column yet.

Similarly when executing a statement which both DROPS and ADDS an index in the same statement, an online alter would be attempted, but the ADD index functionality is not supported yet, causing assertion fail in MyRocks.

Workaround is to only do inplace alter when the operation is a DROP INDEX on secondary key by itself, and not combined with other operations which arent supported yet.

Fixes facebook/mysql-5.6#239

Squash with D54777

Test Plan: Added new test cases to drop_index_inplace that reproduces the issue

Reviewers: hermanlee4, yoshinorim

Reviewed By: yoshinorim

Subscribers: webscalesql-eng

Differential Revision: https://reviews.facebook.net/D57585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alxyang alxyang

Labels
bug myrocks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yoshinorim @alxyang